You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by caofangkun <gi...@git.apache.org> on 2014/10/15 08:17:30 UTC
[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/293
STORM-532,Supervisor should restart worker immediately, if the worker pr...
https://issues.apache.org/jira/browse/STORM-532
For now
if the worker process does not exist any more
Supervisor will have to wait a few seconds for worker heartbeart timeout and restart worker .
If supervisor knows the worker processid and check if the process exists in the sync-processes thread ,may need less time to restart worker.
1: record worker process id in the worker local heartbeart
2: in supervisor sync-processes ,get process id from worker local heartbeat
and check if the process exits
3: if not restart it immediately
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #293
----
commit ab9ae75fe3f3bbf070d05b5b165af04152a5933d
Author: caokun <caokun@caokun-virtualbox.(none)>
Date: 2014-10-15T01:12:11Z
STORM-532,Supervisor should restart worker immediately, if the worker process does not exist any more
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...
Posted by itaifrenkel <gi...@git.apache.org>.
Github user itaifrenkel commented on the pull request:
https://github.com/apache/storm/pull/293#issuecomment-59499800
Hi @caofangkun. Could you then close this pull request?
Please see my comments in #296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun closed the pull request at:
https://github.com/apache/storm/pull/293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/293#discussion_r18947137
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -356,6 +356,10 @@
(first split)
))
+ (defn exists-process?
--- End diff --
Windows users also use Storm, so I think OS specific code should be discouraged, or need to provide alternatives.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...
Posted by itaifrenkel <gi...@git.apache.org>.
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/293#discussion_r18944932
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -114,6 +114,8 @@
:disallowed
(not hb)
:not-started
+ (or ((nil? (:process-id hb)) (not (exists-process? (:process-id hb))) ) )
--- End diff --
check for supported operating systems
http://commons.apache.org/proper/commons-exec/apidocs/org/apache/commons/exec/OS.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/293#issuecomment-59339694
@itaifrenkel
Thank you for your comments
I have fixed with your suggestion, in https://github.com/apache/storm/pull/296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/293#discussion_r18949050
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -356,6 +356,10 @@
(first split)
))
+ (defn exists-process?
--- End diff --
@itaifrenkel
@HeartSaVioR
fixed in https://github.com/apache/storm/pull/296
use tasklist to find pid on windows
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...
Posted by itaifrenkel <gi...@git.apache.org>.
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/293#discussion_r18943315
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -356,6 +356,10 @@
(first split)
))
+ (defn exists-process?
--- End diff --
exists-linux-process
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/293#issuecomment-60419007
@caofangkun If this pull request has been superseded by #296 would you mind closing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-532,Supervisor should restart worker imm...
Posted by itaifrenkel <gi...@git.apache.org>.
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/293#discussion_r18945173
--- Diff: storm-core/src/jvm/backtype/storm/spout/SleepSpoutWaitStrategy.java ---
@@ -33,7 +33,7 @@ public void prepare(Map conf) {
@Override
public void emptyEmit(long streak) {
try {
- Thread.sleep(sleepMillis);
+ Thread.sleep(Math.abs(sleepMillis + streak));
--- End diff --
are you sure this is related to this pull request ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---