You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "toffentoffen (via GitHub)" <gi...@apache.org> on 2023/02/20 15:38:19 UTC
[GitHub] [skywalking] toffentoffen opened a new issue, #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled
toffentoffen opened a new issue, #10419:
URL: https://github.com/apache/skywalking/issues/10419
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
For services with a low rate of requests, for instance 1 per hour, the `cpm` aggregation function loses the requests when it is downsampled to hours or days treating it as effectively 0 requests.
This lose of precision can misleading while being unable to different if there really has been a request or not.
### Use case
Create a new function, for instance `cpm5d` (5 decimals), that doesn't lose precision after downsampling.
We need at least 5 decimals if we want to represent as precise as possible 1 request in a concrete hour of a day, downsampled to days.
The following example is 1 request in a concrete hour or a day. Which means at the end 1 request per day.
1 decimal: 1 / 1440 = 0 // We cannot different anymore
4 decimals: (1 * 10000) / 1440 = 6
5 decimals: (1 * 100000) / 1440 = 69
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10419:
URL: https://github.com/apache/skywalking/issues/10419#issuecomment-1476565316
I think we should to keep consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Fine0830 commented on issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on issue #10419:
URL: https://github.com/apache/skywalking/issues/10419#issuecomment-1477144513
> @Fine0830 Could you remove that? I noticed it mixed with another change.
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10419:
URL: https://github.com/apache/skywalking/issues/10419#issuecomment-1476568101
@Fine0830 Could you remove that? I noticed it mixed with another change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] toffentoffen commented on issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled
Posted by "toffentoffen (via GitHub)" <gi...@apache.org>.
toffentoffen commented on issue #10419:
URL: https://github.com/apache/skywalking/issues/10419#issuecomment-1476542060
Should we revert UI committed changes for the CPM5D function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10419:
URL: https://github.com/apache/skywalking/issues/10419#issuecomment-1476206376
Ref https://github.com/apache/skywalking/pull/10420#issuecomment-1476205729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled
URL: https://github.com/apache/skywalking/issues/10419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org