[GitHub] [pinot] klsince commented on pull request #9624: notify servers that need to move segments to new tiers via SegmentReloadMessage

[GitBox <gi...@apache.org>]

klsince commented on PR #9624:
URL: https://github.com/apache/pinot/pull/9624#issuecomment-1283154881

   > High level question: why is the logic implemented in the table rebalancer? IMO it should be part of the tier assigner
   
   The design decision was made to extend SegmentRelocator (not Assigner either to separate responsibilities). I extended TableRebalancer (used by SegmentRelocator) to check on a condition i.e. 
   ```
   if (currentAssignment.equals(targetAssignment)) {
         LOGGER.info("Table: {} is already balanced", tableNameWithType);
   ...
   ```
   But looks like I can check on `RebalanceResult.Status.DONE` anyway, to move tier migration logic into SegmentRelocator to be clear.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org