You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "mattaubury (via GitHub)" <gi...@apache.org> on 2023/04/27 10:58:58 UTC
[GitHub] [arrow] mattaubury opened a new issue, #35354: [Python][C++?] Dataset "right anti" join gives incorrect result with large_string columns (11.0.0)
mattaubury opened a new issue, #35354:
URL: https://github.com/apache/arrow/issues/35354
### Describe the bug, including details regarding any error messages, version, and platform.
In this example, I'm doing an anti-join between a table and itself - which should result in an empty table. But once the table exceeds 1024 elements, the resulting table is non-empty:
```
import pyarrow as pa
import pyarrow.dataset as ds
N = 1030
strings = pa.array((str(i) for i in range(N)), type=pa.large_string())
table = pa.table([strings], names=["a"])
dataset = ds.dataset(table)
result = dataset.join(dataset, keys=["a"], join_type="right anti")
print(result.to_table())
```
Result:
```
pyarrow.Table
a: large_string
----
a: [["1024","1025","1026","1027","1028","1029"]]
```
The problem is also observed for `large_binary`, but not other types that I've tried such as `string`. Interestingly it also doesn't seem to be a problem for `left anti`.
### Component(s)
C++, Python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Python][C++?] Dataset "right anti" join gives incorrect result with large_string columns (11.0.0) [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF closed issue #35354: [Python][C++?] Dataset "right anti" join gives incorrect result with large_string columns (11.0.0)
URL: https://github.com/apache/arrow/issues/35354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Python][C++?] Dataset "right anti" join gives incorrect result with large_string columns (11.0.0) [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on issue #35354:
URL: https://github.com/apache/arrow/issues/35354#issuecomment-1865811989
This should be fixed, I ran both python and C++ case for `right semi` and `inner` in latest dev branch, the results are correct.
I think it's most likely fixed by #38147, as the related issues #38074 and #37729 have very similar symptom.
@AlenkaF I saw you verified #37729 a couple of days ago. Would you please help to double confirm this as well? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mattaubury commented on issue #35354: [Python][C++?] Dataset "right anti" join gives incorrect result with large_string columns (11.0.0)
Posted by "mattaubury (via GitHub)" <gi...@apache.org>.
mattaubury commented on issue #35354:
URL: https://github.com/apache/arrow/issues/35354#issuecomment-1541833846
This is also an issue with other join types, including `left semi`, `right semi`, and `inner`. For example, in the Python code above, if the `join_type` is set to `"inner"` we get a truncated output:
```
pyarrow.Table
a: large_string
----
a: [["0","1","2","3","4",...,"1019","1020","1021","1022","1023"]]
```
The end of the array should be `"1029"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on issue #35354: [Python][C++?] Dataset "right anti" join gives incorrect result with large_string columns (11.0.0)
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on issue #35354:
URL: https://github.com/apache/arrow/issues/35354#issuecomment-1536892668
I can confirm this with a unit test. I suspect we are overflowing something but I don't see any asan or ubsan violations so it'll take a bit more digging:
```
TEST(HashJoin, LargeString) {
LargeStringBuilder builder;
ASSERT_OK(builder.Reserve(1030));
for (int i = 0; i < 1030; i++) {
ASSERT_OK(builder.Append(std::to_string(i)));
}
ASSERT_OK_AND_ASSIGN(auto arr, builder.Finish());
ExecBatch batch({arr}, 1030);
std::vector<ExecBatch> batches = {batch};
Declaration left{"exec_batch_source", ExecBatchSourceNodeOptions(
schema({field("x", large_utf8())}), batches)};
Declaration right{
"exec_batch_source",
ExecBatchSourceNodeOptions(schema({field("x", large_utf8())}), batches)};
HashJoinNodeOptions join_opts(JoinType::RIGHT_ANTI, {"x"}, {"x"});
Declaration join{"hashjoin", {left, right}, join_opts};
ASSERT_OK_AND_ASSIGN(std::shared_ptr<Table> result, DeclarationToTable(join));
std::cout << result->ToString() << std::endl;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Python][C++?] Dataset "right anti" join gives incorrect result with large_string columns (11.0.0) [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on issue #35354:
URL: https://github.com/apache/arrow/issues/35354#issuecomment-1866468136
I get an empty table as expected:
```python
>>> import pyarrow as pa
>>> pa.__version__
'15.0.0.dev285+g32f13e893.d20231220'
>>> N = 1030
>>> strings = pa.array((str(i) for i in range(N)), type=pa.large_string())
>>> table = pa.table([strings], names=["a"])
>>> dataset = ds.dataset(table)
>>> result = dataset.join(dataset, keys=["a"], join_type="right anti")
>>> print(result.to_table())
pyarrow.Table
a: large_string
----
a: []
```
Closing this issue, thanks for the ping!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org