You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Junjie Peng (JIRA)" <ji...@apache.org> on 2008/07/07 05:41:31 UTC
[jira] Created: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
-----------------------------------------------------------------------------------------------------
Key: DERBY-3759
URL: https://issues.apache.org/jira/browse/DERBY-3759
Project: Derby
Issue Type: Test
Components: Test
Environment: windows xp, sp2.
Reporter: Junjie Peng
Assignee: Junjie Peng
Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613514#action_12613514 ]
Junjie Peng commented on DERBY-3759:
------------------------------------
Kathey, I have reviewed the code. And found, I just added these test classes in the tail of this file by hand. However, I think they are not in the "if" branch, they will be executed always no matter whether JSR169 is supported. What's your opinion?
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3759
> URL: https://issues.apache.org/jira/browse/DERBY-3759
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3759-1-patch.txt, derby-3759-1-stat.txt, derby-3759-2-patch.txt, derby-3759-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-3759:
--------------------------------------
Fix Version/s: 10.5.0.0
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3759
> URL: https://issues.apache.org/jira/browse/DERBY-3759
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Fix For: 10.5.0.0
>
> Attachments: derby-3759-1-patch.txt, derby-3759-1-stat.txt, derby-3759-2-patch.txt, derby-3759-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612735#action_12612735 ]
Junjie Peng commented on DERBY-3759:
------------------------------------
OK, I've got it. Thanks!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3759
> URL: https://issues.apache.org/jira/browse/DERBY-3759
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3759-1-patch.txt, derby-3759-1-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613599#action_12613599 ]
Kathey Marsden commented on DERBY-3759:
---------------------------------------
You are right Junjie, I'm sorry I misread the code.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3759
> URL: https://issues.apache.org/jira/browse/DERBY-3759
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3759-1-patch.txt, derby-3759-1-stat.txt, derby-3759-2-patch.txt, derby-3759-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng resolved DERBY-3759.
--------------------------------
Resolution: Fixed
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3759
> URL: https://issues.apache.org/jira/browse/DERBY-3759
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3759-1-patch.txt, derby-3759-1-stat.txt, derby-3759-2-patch.txt, derby-3759-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3759:
-------------------------------
Attachment: derby-3759-1-stat.txt
derby-3759-1-patch.txt
Please check the patch!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3759
> URL: https://issues.apache.org/jira/browse/DERBY-3759
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3759-1-patch.txt, derby-3759-1-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613491#action_12613491 ]
Kathey Marsden commented on DERBY-3759:
---------------------------------------
I committed this patch but moved the test to the section of the suite that runs with JSR169.
I noticed also the following tests are in the section to omit with JSR 169
suite.addTest(BigDataTest.suite());
suite.addTest(MixedCaseExpressionTest.suite());
suite.addTest(MiscErrorsTest.suite());
Is there a reason these shouldn't run with JSR169?
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3759
> URL: https://issues.apache.org/jira/browse/DERBY-3759
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3759-1-patch.txt, derby-3759-1-stat.txt, derby-3759-2-patch.txt, derby-3759-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612587#action_12612587 ]
Kathey Marsden commented on DERBY-3759:
---------------------------------------
You need to remove the test from derbylang.runall. Otherwise the patch looks fine.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3759
> URL: https://issues.apache.org/jira/browse/DERBY-3759
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3759-1-patch.txt, derby-3759-1-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng closed DERBY-3759.
------------------------------
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3759
> URL: https://issues.apache.org/jira/browse/DERBY-3759
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3759-1-patch.txt, derby-3759-1-stat.txt, derby-3759-2-patch.txt, derby-3759-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3759) Convert
"org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql"
to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3759:
-------------------------------
Attachment: derby-3759-2-stat.txt
derby-3759-2-patch.txt
I have removed it. Please check it, thanks!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit.
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3759
> URL: https://issues.apache.org/jira/browse/DERBY-3759
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3759-1-patch.txt, derby-3759-1-stat.txt, derby-3759-2-patch.txt, derby-3759-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.ungroupedAggregatesNegative.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.