You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/01 05:55:00 UTC
[jira] [Work logged] (BEAM-8513) RabbitMqIO: Allow reads from
exchange-bound queue without declaring the exchange
[ https://issues.apache.org/jira/browse/BEAM-8513?focusedWorklogId=337196&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337196 ]
ASF GitHub Bot logged work on BEAM-8513:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/19 05:54
Start Date: 01/Nov/19 05:54
Worklog Time Spent: 10m
Work Description: jbonofre commented on pull request #9937: [BEAM-8513] Allow reads from exchange-bound queue without declaring the exchange
URL: https://github.com/apache/beam/pull/9937#discussion_r341458821
##########
File path: sdks/java/io/rabbitmq/src/main/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIO.java
##########
@@ -453,6 +524,8 @@ public boolean start() throws IOException {
// we consume message without autoAck (we want to do the ack ourselves)
channel.setDefaultConsumer(consumer);
channel.basicConsume(queueName, false, consumer);
+ } catch (IOException e) {
+ throw e;
Review comment:
Agree, no need. My bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 337196)
Time Spent: 2h (was: 1h 50m)
> RabbitMqIO: Allow reads from exchange-bound queue without declaring the exchange
> --------------------------------------------------------------------------------
>
> Key: BEAM-8513
> URL: https://issues.apache.org/jira/browse/BEAM-8513
> Project: Beam
> Issue Type: Improvement
> Components: io-java-rabbitmq
> Environment: testing with DirectRunner
> Reporter: Nick Aldwin
> Assignee: Jean-Baptiste Onofré
> Priority: Critical
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The RabbitMqIO always declares an exchange if it is configured to read from it. This is problematic with pre-existing exchanges (a relatively common pattern), as there's no provided configuration for the exchange beyond exchange type. (We stumbled on this because RabbitMqIO always declares a non-durable exchange, which fails if the exchange already exists as a durable exchange)
>
> A solution to this would be to allow RabbitMqIO to read from an exchange without declaring it. This pattern is already available for queues via the `queueDeclare` flag. I propose an `exchangeDeclare` flag which preserves existing behavior except for skipping the call to `exchangeDeclare` before binding the queue to the exchange.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)