You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wilderrodrigues <gi...@git.apache.org> on 2015/12/11 18:46:03 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1221
CLOUDSTACK-9135 - As a Developer I want the test_internal_lb.py to test Redundant VPCs
This PR refactors the existing tests and adds tests to cover internal LB with Redundant VPCs.
In order to make it possible I had to change the base.py, allowing multiple providers per service. This change requires the changes in the Java side which were dealt with PR #1215 .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ekholabs/cloudstack improve/test-internal-lb-CLOUDSTACK-9135
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1221
----
commit 632ee18ab709f0d0255796e50198ec8fd97e968a
Author: Wilder Rodrigues <wr...@schubergphilis.com>
Date: 2015-12-10T12:27:53Z
CLOUDSTACK-9135 - Moves test into smoke directory
- Missed this test when moved the other 5 ones.
commit 590af145b0c703f9c957c6f81ef450856dc2c407
Author: Wilder Rodrigues <wr...@schubergphilis.com>
Date: 2015-12-11T14:02:55Z
CLOUDSTACK-9135 - Makes possible to add multiple providers per service
- Same is done in the Java side. Check the createVpcOffering() method in the VpcManagerImpl class
commit 43ce049d43ce7aa0e4d25b0630cbcd1c423156b9
Author: Wilder Rodrigues <wr...@schubergphilis.com>
Date: 2015-12-11T14:03:50Z
CLOUDSTACK-9135 - Makes test compliant with Redundant VPCs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164071815
Hi @wilderrodrigues ,
Looks good! Thanks for making the tests compliant!
```
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Single VPC ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Redundant VPC ... === TestName: test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 4 tests in 5901.365s
```
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1221#discussion_r47416109
--- Diff: test/integration/smoke/test_internal_lb.py ---
@@ -286,9 +302,12 @@ def setUpClass(cls):
%s" % (cls.account.name,
cls.account.id))
- cls.cleanup = [cls.template, cls.account, cls.compute_offering]
+ cls._cleanup = [cls.template, cls.account, cls.compute_offering]
--- End diff --
Why use the prefix _ here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164001738
Ping @remibergsma @DaanHoogland @borisroman @michaelandersen @bhaisaab @karuturi @miguelaferreira
Please, keep in mind that this PR depends on PR #1215.
* Environment
- 1 KVM host on CentOS 7.1
- Management Server on CentOS 7.1
- Agent + Common RPMs built from source
* Test executed
```
nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone2-kvm2-ISOLATED.cfg -s -a tags=advanced,required_hardware=true smoke/test_internal_lb.py
```
* Results
```
[root@cs2 integration]# less /tmp//MarvinLogs/test_internal_lb_DXYD14/results.txt
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Single VPC ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Redundant VPC ... === TestName: test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 4 tests in 6681.151s
OK
/tmp//MarvinLogs/test_internal_lb_DXYD14/results.txt (END)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164137434
LGTM based on running the tests:
```
[root@cs1 integration]# cat /tmp//MarvinLogs/test_internal_lb_SFTBEY/results.txt
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Single VPC ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Redundant VPC ... === TestName: test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 4 tests in 3847.453s
OK
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164135820
Thanks for the reviw, @borisroman! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1221#discussion_r47429990
--- Diff: test/integration/smoke/test_internal_lb.py ---
@@ -286,9 +302,12 @@ def setUpClass(cls):
%s" % (cls.account.name,
cls.account.id))
- cls.cleanup = [cls.template, cls.account, cls.compute_offering]
+ cls._cleanup = [cls.template, cls.account, cls.compute_offering]
--- End diff --
Hi @borisroman
I added a setUp() and tearDown() methods that are called before/after each test. By doing so, we make sure that each test is done in isolation.
The tearDown() method uses the cleanup list, whilst the tearDownClass() method uses the _cleanup list.
The tearDownClass() is called only when all the tests are done.
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---