You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@livy.apache.org by GitBox <gi...@apache.org> on 2022/12/13 18:15:13 UTC
[GitHub] [incubator-livy] lmccay opened a new pull request, #371: LIVY-903 - Address Netty Upgrades for 0.8.0
lmccay opened a new pull request, #371:
URL: https://github.com/apache/incubator-livy/pull/371
LIVY-903 - Address Netty Upgrades for 0.8.0
## What changes were proposed in this pull request?
Upgrade of netty version from 4.1.17 to 4.1.71
## How was this patch tested?
Build with unit and integration tests.
Please review https://livy.incubator.apache.org/community/ before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] dacort commented on a diff in pull request #371: LIVY-903 - Address Netty Upgrades for 0.8.0
Posted by GitBox <gi...@apache.org>.
dacort commented on code in PR #371:
URL: https://github.com/apache/incubator-livy/pull/371#discussion_r1047869152
##########
pom.xml:
##########
@@ -100,8 +100,8 @@
<kryo.version>4.0.2</kryo.version>
<metrics.version>3.1.0</metrics.version>
<mockito.version>1.10.19</mockito.version>
- <netty.spark-2.11.version>4.1.17.Final</netty.spark-2.11.version>
- <netty.spark-2.12.version>4.1.17.Final</netty.spark-2.12.version>
+ <netty.spark-2.11.version>4.1.71.Final</netty.spark-2.11.version>
Review Comment:
Any reason we didn't go higher? 4.1.86 is out, but it's tough to tell what the diff / impact is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] lmccay merged pull request #371: LIVY-903 - Address Netty Upgrades for 0.8.0
Posted by GitBox <gi...@apache.org>.
lmccay merged PR #371:
URL: https://github.com/apache/incubator-livy/pull/371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] codecov-commenter commented on pull request #371: LIVY-903 - Address Netty Upgrades for 0.8.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #371:
URL: https://github.com/apache/incubator-livy/pull/371#issuecomment-1352270381
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#371](https://codecov.io/gh/apache/incubator-livy/pull/371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (73f6c70) into [master](https://codecov.io/gh/apache/incubator-livy/commit/41304e8ef1d82127740820b4998fd54f8137ee60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41304e8) will **decrease** coverage by `2.65%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #371 +/- ##
============================================
- Coverage 68.39% 65.73% -2.66%
+ Complexity 843 816 -27
============================================
Files 103 103
Lines 5948 5948
Branches 899 899
============================================
- Hits 4068 3910 -158
- Misses 1319 1512 +193
+ Partials 561 526 -35
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/livy/server/ThriftServerFactory.scala](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvVGhyaWZ0U2VydmVyRmFjdG9yeS5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `2.23% <0.00%> (-29.92%)` | :arrow_down: |
| [...rc/main/scala/org/apache/livy/utils/SparkApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya0FwcC5zY2FsYQ==) | `56.00% <0.00%> (-20.00%)` | :arrow_down: |
| [core/src/main/scala/org/apache/livy/Logging.scala](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvTG9nZ2luZy5zY2FsYQ==) | `66.66% <0.00%> (-16.67%)` | :arrow_down: |
| [...e/livy/server/interactive/InteractiveSession.scala](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uLnNjYWxh) | `56.97% <0.00%> (-12.80%)` | :arrow_down: |
| [...src/main/scala/org/apache/livy/sessions/Kind.scala](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvc2Vzc2lvbnMvS2luZC5zY2FsYQ==) | `66.66% <0.00%> (-9.53%)` | :arrow_down: |
| [...la/org/apache/livy/utils/LineBufferedProcess.scala](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9MaW5lQnVmZmVyZWRQcm9jZXNzLnNjYWxh) | `78.57% <0.00%> (-7.15%)` | :arrow_down: |
| [...server/interactive/InteractiveSessionServlet.scala](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uU2VydmxldC5zY2FsYQ==) | `61.41% <0.00%> (-6.30%)` | :arrow_down: |
| [.../scala/org/apache/livy/server/SessionServlet.scala](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvU2Vzc2lvblNlcnZsZXQuc2NhbGE=) | `66.31% <0.00%> (-5.27%)` | :arrow_down: |
| [...org/apache/livy/server/recovery/SessionStore.scala](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvcmVjb3ZlcnkvU2Vzc2lvblN0b3JlLnNjYWxh) | `75.00% <0.00%> (-5.00%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/incubator-livy/pull/371/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] lmccay commented on pull request #371: LIVY-903 - Address Netty Upgrades for 0.8.0
Posted by GitBox <gi...@apache.org>.
lmccay commented on PR #371:
URL: https://github.com/apache/incubator-livy/pull/371#issuecomment-1352326082
Triggered a new build as I think it is likely a flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] lmccay commented on a diff in pull request #371: LIVY-903 - Address Netty Upgrades for 0.8.0
Posted by GitBox <gi...@apache.org>.
lmccay commented on code in PR #371:
URL: https://github.com/apache/incubator-livy/pull/371#discussion_r1047872458
##########
pom.xml:
##########
@@ -100,8 +100,8 @@
<kryo.version>4.0.2</kryo.version>
<metrics.version>3.1.0</metrics.version>
<mockito.version>1.10.19</mockito.version>
- <netty.spark-2.11.version>4.1.17.Final</netty.spark-2.11.version>
- <netty.spark-2.12.version>4.1.17.Final</netty.spark-2.12.version>
+ <netty.spark-2.11.version>4.1.71.Final</netty.spark-2.11.version>
Review Comment:
Good question, I just looked for the one above the last reported issue. Let me do some more digging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org