[jira] Commented: (HIVE-1498) support IDXPROPERTIES on CREATE/ALTER INDEX

["John Sichi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912705#action_12912705 ] 

John Sichi commented on HIVE-1498:
----------------------------------

Good start.  A few notes:

* I had to use patch -p1 to get this to apply.  Please make sure it applies with patch -p0 instead.

* In Hive.createIndex, you should be adding the tblProps to tt (not to temp).  The only purpose of temp is to check whether the new table name already exists (in which case an exception is thrown).  tt is the newly created table descriptor to be added to the metastore.

* For the next patch candidate, can you also add support for ALTER INDEX index_name ON table_name SET IDXPROPERTIES (...)?  Or open a followup JIRA issue for this.

* Go ahead and add unit test coverage even though it's not actually possible to verify the IDXPROPERTIES results until HIVE-1497 goes in.  You can modify ql/src/test/queries/clientpositive/index_creation.q, or create a new index_props.q.  Also, you should be able to verify the TBLPROPERTIES results already by doing DESCRIBE EXTENDED on the new table created by CREATE INDEX.

* Cosmetic:  For if statements, put the opening curly brace on the same line as the keyword.  You can run ant checkstyle and look in the report for the files you modified to see formatting which needs corrected.


> support IDXPROPERTIES on CREATE/ALTER INDEX
> -------------------------------------------
>
>                 Key: HIVE-1498
>                 URL: https://issues.apache.org/jira/browse/HIVE-1498
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Indexing
>    Affects Versions: 0.7.0
>            Reporter: John Sichi
>            Assignee: Russell Melick
>             Fix For: 0.7.0
>
>         Attachments: hive-1498.prelim.patch
>
>
> It's partially there in the grammar but not hooked in; should work pretty much the same as TBLPROPERTIES.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.