You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "olegkachur-e (via GitHub)" <gi...@apache.org> on 2026/08/28 12:33:19 UTC
[PR] Fix google provider system tests dag version increase issues [airflow]
olegkachur-e opened a new pull request, #72194:
URL: https://github.com/apache/airflow/pull/72194
- Using dynamic values inside the dag results into increasing dag version on each parse cycle, which confusing and discouraged.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix google provider system tests dag version increase issues [airflow]
Posted by "olegkachur-e (via GitHub)" <gi...@apache.org>.
olegkachur-e commented on code in PR #72194:
URL: https://github.com/apache/airflow/pull/72194#discussion_r4063537619
##########
providers/google/src/airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py:
##########
@@ -264,12 +264,12 @@ def __init__(
self.api_version = api_version
self.project_id = project_id
self.google_impersonation_chain = google_impersonation_chain
- self._validate_inputs()
def _validate_inputs(self) -> None:
TransferJobValidator(body=self.body).validate_body()
def execute(self, context: Context) -> dict:
+ self._validate_inputs()
Review Comment:
Addressed in the https://github.com/apache/airflow/pull/73460, will rebase this one after the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix google provider system tests dag version increase issues [airflow]
Posted by "molcay (via GitHub)" <gi...@apache.org>.
molcay commented on PR #72194:
URL: https://github.com/apache/airflow/pull/72194#issuecomment-6147156052
Hi @potiuk,
Can you revert your fixup commit for the PR?
It is causing the failure on the system test for the `example_cloud_composer.py`.
We need to have the `datetime.now()` in the `execution_range` parameter to calcuate execution dates correctly and fetch it from Airflow API inside of the Composer environment.
We must have something like this: https://github.com/apache/airflow/pull/72194/changes/1d9b8d539767dad8b3541ff49a40725cdaa036db#diff-8d0e2a629064bbf974e84b69df1a282cf2b2e3afad62b10b133d4e27a82bd0be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix google provider system tests dag version increase issues [airflow]
Posted by "olegkachur-e (via GitHub)" <gi...@apache.org>.
olegkachur-e commented on code in PR #72194:
URL: https://github.com/apache/airflow/pull/72194#discussion_r4024445682
##########
providers/google/src/airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py:
##########
@@ -264,12 +264,12 @@ def __init__(
self.api_version = api_version
self.project_id = project_id
self.google_impersonation_chain = google_impersonation_chain
- self._validate_inputs()
def _validate_inputs(self) -> None:
TransferJobValidator(body=self.body).validate_body()
def execute(self, context: Context) -> dict:
+ self._validate_inputs()
Review Comment:
> Good catch, but doesn't seem related to the PR.
Sure, I'll prepare a new one and update this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix google provider system tests dag version increase issues [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #72194:
URL: https://github.com/apache/airflow/pull/72194#discussion_r4015702789
##########
providers/google/src/airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py:
##########
@@ -264,12 +264,12 @@ def __init__(
self.api_version = api_version
self.project_id = project_id
self.google_impersonation_chain = google_impersonation_chain
- self._validate_inputs()
def _validate_inputs(self) -> None:
TransferJobValidator(body=self.body).validate_body()
def execute(self, context: Context) -> dict:
+ self._validate_inputs()
Review Comment:
Good catch, but doesn't seem related to the PR.
Could you please create a separate PR for that? (it also needs to be removed from generated/validate_operators_init_exemptions.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix google provider system tests dag version increase issues [airflow]
Posted by "olegkachur-e (via GitHub)" <gi...@apache.org>.
olegkachur-e commented on code in PR #72194:
URL: https://github.com/apache/airflow/pull/72194#discussion_r4063537619
##########
providers/google/src/airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py:
##########
@@ -264,12 +264,12 @@ def __init__(
self.api_version = api_version
self.project_id = project_id
self.google_impersonation_chain = google_impersonation_chain
- self._validate_inputs()
def _validate_inputs(self) -> None:
TransferJobValidator(body=self.body).validate_body()
def execute(self, context: Context) -> dict:
+ self._validate_inputs()
Review Comment:
Addressed in the https://github.com/apache/airflow/pull/73460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix google provider system tests dag version increase issues [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #72194:
URL: https://github.com/apache/airflow/pull/72194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org