[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

["valerybokov (via GitHub)" <gi...@apache.org>]

valerybokov commented on PR #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1616657543

   Hi, @THauserr! The comment to the PDColor.toRGB method says "throws IllegalStateException if this color value is a pattern." I checked several color spaces and found that they either throw an UnsupportedOperationException or don't throw an exception. PDPattern color space throws UnsupportedOperationException too. Actually, I think, UnsupportedOperationException is better here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org