You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "SanjayUG (via GitHub)" <gi...@apache.org> on 2025/03/19 11:06:37 UTC

[PR] #5483 [datafusion]

SanjayUG opened a new pull request, #15307:
URL: https://github.com/apache/datafusion/pull/15307

   # Add Subquery Support for BETWEEN Expressions
   
   ## Which issue does this PR close?
   
   - Closes #5483.
   
   ## Rationale for this change
   
   This change adds support for scalar subqueries in BETWEEN lower and upper bounds, enhancing the flexibility of query expressions. By enabling subqueries within BETWEEN expressions, we provide users with more powerful and expressive query capabilities.
   
   ## What changes are included in this PR?
   
   - **feat:** Add subquery support for BETWEEN expressions
     - Add support for scalar subqueries in BETWEEN lower and upper bounds
     - Add `new_with_subqueries` method to validate subquery expressions
     - Update SQL and physical planners to handle subqueries
     - Add documentation with examples and usage patterns
   
   ## Are these changes tested?
   
   Yes, the changes are tested to ensure that subqueries in BETWEEN expressions are correctly validated and executed. Tests cover various use cases and edge cases to verify the robustness of the implementation.
   
   ## Are there any user-facing changes?
   
   Yes, users will now be able to use scalar subqueries within BETWEEN expressions in their SQL queries. Documentation has been updated to include examples and usage patterns for this new feature.
   
   ## Are there any breaking changes to public APIs?
   
   No, there are no breaking changes to public APIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] #5483 [datafusion]

Posted by "irenjj (via GitHub)" <gi...@apache.org>.
irenjj commented on code in PR #15307:
URL: https://github.com/apache/datafusion/pull/15307#discussion_r2003186287


##########
.github/workflows/dev.yml:
##########
@@ -28,7 +28,7 @@ jobs:
     name: Check License Header
     steps:
       - uses: actions/checkout@v4
-      - uses: korandoru/hawkeye@v6
+      - uses: korandoru/hawkeye@e8a6f7b6e9f6e0c3e8c5e9a6f7b6e9f6e0c3e8c5

Review Comment:
   No need to change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] #5483 [datafusion]

Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on PR #15307:
URL: https://github.com/apache/datafusion/pull/15307#issuecomment-2743108401

   - `cargo fmt`
   - [prettier](https://datafusion.apache.org/contributor-guide/howtos.html#how-to-format-md-document)
   - revert the hawkeye github action changes (separate PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] #5483 [datafusion]

Posted by "irenjj (via GitHub)" <gi...@apache.org>.
irenjj commented on PR #15307:
URL: https://github.com/apache/datafusion/pull/15307#issuecomment-2736317386

   Thanks @SanjayUG , but I think this pr is part of #5483, instead of closing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] #5483 [datafusion]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #15307: #5483
URL: https://github.com/apache/datafusion/pull/15307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] #5483 [datafusion]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15307:
URL: https://github.com/apache/datafusion/pull/15307#issuecomment-2899697745

   Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] #5483 [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #15307:
URL: https://github.com/apache/datafusion/pull/15307#issuecomment-2737792933

   Thanks @SanjayUG  -- it looks like there are some CI failures so marking this PR as a draft for now 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org