You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Carlos Sanchez (JIRA)" <ji...@codehaus.org> on 2006/04/29 09:02:19 UTC

[jira] Created: (MNG-2255) Use a external XML Pull parser instead of plexus one

Use a external XML Pull parser instead of plexus one
----------------------------------------------------

         Key: MNG-2255
         URL: http://jira.codehaus.org/browse/MNG-2255
     Project: Maven 2
        Type: Improvement

  Components: POM  
    Versions: 2.0.4    
    Reporter: Carlos Sanchez


To avoid maintaining the plexus XMLPullParser we should move to a standard implementation like StaX

As mentioned in DOXIA-60:

There's a performance white paper
http://java.sun.com/performance/reference/whitepapers/StAX-1_0.pdf

The best implementation seems to be http://woodstox.codehaus.org/

Another nice set of utilities at http://wiki.java.net/bin/view/Javawsxml/StaxUtilsProject

The indentator could be used instead of the PrettyPrintXMLWriter


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2255) Use a external XML Pull parser instead of plexus one

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2255?page=all ]

Carlos Sanchez updated MNG-2255:
--------------------------------

       Priority: Critical  (was: Major)
    Fix Version: 2.0.5

Seems by related issues that people is having a lot of trouble with encodings

> Use a external XML Pull parser instead of plexus one
> ----------------------------------------------------
>
>          Key: MNG-2255
>          URL: http://jira.codehaus.org/browse/MNG-2255
>      Project: Maven 2
>         Type: Improvement

>   Components: POM
>     Versions: 2.0.4
>     Reporter: Carlos Sanchez
>     Priority: Critical
>      Fix For: 2.0.5

>
>
> To avoid maintaining the plexus XMLPullParser we should move to a standard implementation like StaX
> As mentioned in DOXIA-60:
> There's a performance white paper
> http://java.sun.com/performance/reference/whitepapers/StAX-1_0.pdf
> The best implementation seems to be http://woodstox.codehaus.org/
> Another nice set of utilities at http://wiki.java.net/bin/view/Javawsxml/StaxUtilsProject
> The indentator could be used instead of the PrettyPrintXMLWriter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (MNG-2255) Use a external XML Pull parser instead of plexus one

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason van Zyl closed MNG-2255.
------------------------------

    Resolution: Fixed

We are now using the StAX parser from the Woodstox project.

> Use a external XML Pull parser instead of plexus one
> ----------------------------------------------------
>
>                 Key: MNG-2255
>                 URL: http://jira.codehaus.org/browse/MNG-2255
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.4
>            Reporter: Carlos Sanchez
>            Priority: Critical
>             Fix For: 3.0
>
>
> To avoid maintaining the plexus XMLPullParser we should move to a standard implementation like StaX
> As mentioned in DOXIA-60:
> There's a performance white paper
> http://java.sun.com/performance/reference/whitepapers/StAX-1_0.pdf
> The best implementation seems to be http://woodstox.codehaus.org/
> Another nice set of utilities at http://wiki.java.net/bin/view/Javawsxml/StaxUtilsProject
> The indentator could be used instead of the PrettyPrintXMLWriter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2255) Use a external XML Pull parser instead of plexus one

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2255?page=comments#action_65080 ] 

Carlos Sanchez commented on MNG-2255:
-------------------------------------

Yes, that's part of the solution too

> Use a external XML Pull parser instead of plexus one
> ----------------------------------------------------
>
>          Key: MNG-2255
>          URL: http://jira.codehaus.org/browse/MNG-2255
>      Project: Maven 2
>         Type: Improvement

>   Components: POM
>     Versions: 2.0.4
>     Reporter: Carlos Sanchez
>     Priority: Critical
>      Fix For: 2.0.5

>
>
> To avoid maintaining the plexus XMLPullParser we should move to a standard implementation like StaX
> As mentioned in DOXIA-60:
> There's a performance white paper
> http://java.sun.com/performance/reference/whitepapers/StAX-1_0.pdf
> The best implementation seems to be http://woodstox.codehaus.org/
> Another nice set of utilities at http://wiki.java.net/bin/view/Javawsxml/StaxUtilsProject
> The indentator could be used instead of the PrettyPrintXMLWriter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2255) Use a external XML Pull parser instead of plexus one

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason van Zyl updated MNG-2255:
-------------------------------


>From looking at the related issues I think the crux of the problem is using a Reader instead of an InputStream.

> Use a external XML Pull parser instead of plexus one
> ----------------------------------------------------
>
>                 Key: MNG-2255
>                 URL: http://jira.codehaus.org/browse/MNG-2255
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.4
>            Reporter: Carlos Sanchez
>            Priority: Critical
>             Fix For: 2.1.x
>
>
> To avoid maintaining the plexus XMLPullParser we should move to a standard implementation like StaX
> As mentioned in DOXIA-60:
> There's a performance white paper
> http://java.sun.com/performance/reference/whitepapers/StAX-1_0.pdf
> The best implementation seems to be http://woodstox.codehaus.org/
> Another nice set of utilities at http://wiki.java.net/bin/view/Javawsxml/StaxUtilsProject
> The indentator could be used instead of the PrettyPrintXMLWriter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-2255) Use a external XML Pull parser instead of plexus one

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2255?page=all ]

John Casey updated MNG-2255:
----------------------------

    Fix Version:     (was: 2.0.5)
                 2.1

this will require the implementation of a woodstox (or other StaX parser) plugin for Modello, in order to allow us to generate an appropriate model parser.

> Use a external XML Pull parser instead of plexus one
> ----------------------------------------------------
>
>          Key: MNG-2255
>          URL: http://jira.codehaus.org/browse/MNG-2255
>      Project: Maven 2
>         Type: Improvement

>   Components: POM
>     Versions: 2.0.4
>     Reporter: Carlos Sanchez
>     Priority: Critical
>      Fix For: 2.1

>
>
> To avoid maintaining the plexus XMLPullParser we should move to a standard implementation like StaX
> As mentioned in DOXIA-60:
> There's a performance white paper
> http://java.sun.com/performance/reference/whitepapers/StAX-1_0.pdf
> The best implementation seems to be http://woodstox.codehaus.org/
> Another nice set of utilities at http://wiki.java.net/bin/view/Javawsxml/StaxUtilsProject
> The indentator could be used instead of the PrettyPrintXMLWriter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2255) Use a external XML Pull parser instead of plexus one

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MNG-2255:
------------------------------

    Fix Version/s:     (was: 3.0)
                   3.0-alpha-1

> Use a external XML Pull parser instead of plexus one
> ----------------------------------------------------
>
>                 Key: MNG-2255
>                 URL: http://jira.codehaus.org/browse/MNG-2255
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.4
>            Reporter: Carlos Sanchez
>            Priority: Critical
>             Fix For: 3.0-alpha-1
>
>
> To avoid maintaining the plexus XMLPullParser we should move to a standard implementation like StaX
> As mentioned in DOXIA-60:
> There's a performance white paper
> http://java.sun.com/performance/reference/whitepapers/StAX-1_0.pdf
> The best implementation seems to be http://woodstox.codehaus.org/
> Another nice set of utilities at http://wiki.java.net/bin/view/Javawsxml/StaxUtilsProject
> The indentator could be used instead of the PrettyPrintXMLWriter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2255) Use a external XML Pull parser instead of plexus one

Posted by "Stefan H?bner (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2255?page=comments#action_65075 ] 

Stefan Hübner commented on MNG-2255:
------------------------------------

Hm, just a thought, but:

To me it seems that the parser used to read in maven's model isn't the problem really. It's more likely the way the POM is handed to the parser.

Have a look to class org.apache.maven.model.io.xpp3.MavenXpp3Reader which is generated by maven-model. This MavenXpp3Reader is invoked via read-method with one parameter. This parameter is a Reader and that, to me, is problematic. Problematic because there's no way once you have a Reader on some inputsource (i.e. a stream) to change that reader's handling of character encodings on it's underlying stream. So, as long as reading the model is invoked by handing a Reader to some parser the parser won't be able to adapt to the actual POM's encoding.

As a conclusion I would recommend model parser should be handed a stream rather than a Reader-instance working on the underlying POM.

I don't know if other parsers can cope with that situation, but XMLPullParser doesn't. It would though, if it is given a stream on the POM, but I don't know which wider implications this would cause.

What do you think?

> Use a external XML Pull parser instead of plexus one
> ----------------------------------------------------
>
>          Key: MNG-2255
>          URL: http://jira.codehaus.org/browse/MNG-2255
>      Project: Maven 2
>         Type: Improvement

>   Components: POM
>     Versions: 2.0.4
>     Reporter: Carlos Sanchez
>     Priority: Critical
>      Fix For: 2.0.5

>
>
> To avoid maintaining the plexus XMLPullParser we should move to a standard implementation like StaX
> As mentioned in DOXIA-60:
> There's a performance white paper
> http://java.sun.com/performance/reference/whitepapers/StAX-1_0.pdf
> The best implementation seems to be http://woodstox.codehaus.org/
> Another nice set of utilities at http://wiki.java.net/bin/view/Javawsxml/StaxUtilsProject
> The indentator could be used instead of the PrettyPrintXMLWriter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MNG-2255) Use a external XML Pull parser instead of plexus one

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123232 ] 

Brett Porter commented on MNG-2255:
-----------------------------------

this is now in place in the branch for MNG-3397

> Use a external XML Pull parser instead of plexus one
> ----------------------------------------------------
>
>                 Key: MNG-2255
>                 URL: http://jira.codehaus.org/browse/MNG-2255
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: POM
>    Affects Versions: 2.0.4
>            Reporter: Carlos Sanchez
>            Priority: Critical
>             Fix For: 2.1
>
>
> To avoid maintaining the plexus XMLPullParser we should move to a standard implementation like StaX
> As mentioned in DOXIA-60:
> There's a performance white paper
> http://java.sun.com/performance/reference/whitepapers/StAX-1_0.pdf
> The best implementation seems to be http://woodstox.codehaus.org/
> Another nice set of utilities at http://wiki.java.net/bin/view/Javawsxml/StaxUtilsProject
> The indentator could be used instead of the PrettyPrintXMLWriter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira