You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/11/16 05:04:38 UTC
[kudu-CR] dist test: enable sharding of a few more tests
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8565
to review the following change.
Change subject: dist_test: enable sharding of a few more tests
......................................................................
dist_test: enable sharding of a few more tests
Adds sharding for rowset_tree-test, tablet_copy-itest, and
delete_tablet-itest which are the longest-running non-sharded tests in
recent builds such as [1]
[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1510801703.18407
Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
---
M build-support/dist_test.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/8565/1
--
To view, visit http://gerrit.cloudera.org:8080/8565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
Gerrit-Change-Number: 8565
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] dist test: enable sharding of a few more tests
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8565 )
Change subject: dist_test: enable sharding of a few more tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8565/1/build-support/dist_test.py
File build-support/dist_test.py:
http://gerrit.cloudera.org:8080/#/c/8565/1/build-support/dist_test.py@98
PS1, Line 98: 'rowset_tree-test': 6
: 'tablet_copy-itest': 6
Is this missing a comma(s)?
--
To view, visit http://gerrit.cloudera.org:8080/8565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
Gerrit-Change-Number: 8565
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 16 Nov 2017 19:21:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] dist test: enable sharding of a few more tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8565 )
Change subject: dist_test: enable sharding of a few more tests
......................................................................
dist_test: enable sharding of a few more tests
Adds sharding for rowset_tree-test, tablet_copy-itest, and
delete_tablet-itest which are the longest-running non-sharded tests in
recent builds such as [1]
[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1510801703.18407
Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
Reviewed-on: http://gerrit.cloudera.org:8080/8565
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M build-support/dist_test.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Dan Burkert: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
Gerrit-Change-Number: 8565
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] dist test: enable sharding of a few more tests
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8565 )
Change subject: dist_test: enable sharding of a few more tests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
Gerrit-Change-Number: 8565
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Nov 2017 00:46:14 +0000
Gerrit-HasComments: No
[kudu-CR] dist test: enable sharding of a few more tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8565
to look at the new patch set (#2).
Change subject: dist_test: enable sharding of a few more tests
......................................................................
dist_test: enable sharding of a few more tests
Adds sharding for rowset_tree-test, tablet_copy-itest, and
delete_tablet-itest which are the longest-running non-sharded tests in
recent builds such as [1]
[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1510801703.18407
Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
---
M build-support/dist_test.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/8565/2
--
To view, visit http://gerrit.cloudera.org:8080/8565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
Gerrit-Change-Number: 8565
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] dist test: enable sharding of a few more tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8565 )
Change subject: dist_test: enable sharding of a few more tests
......................................................................
Patch Set 2: Verified+1
Unrelated test flakiness issues w/ infra
--
To view, visit http://gerrit.cloudera.org:8080/8565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
Gerrit-Change-Number: 8565
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Nov 2017 21:26:08 +0000
Gerrit-HasComments: No
[kudu-CR] dist test: enable sharding of a few more tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8565 )
Change subject: dist_test: enable sharding of a few more tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8565/1/build-support/dist_test.py
File build-support/dist_test.py:
http://gerrit.cloudera.org:8080/#/c/8565/1/build-support/dist_test.py@98
PS1, Line 98: 'rowset_tree-test': 6
: 'tablet_copy-itest': 6
> Is this missing a comma(s)?
yep :(
--
To view, visit http://gerrit.cloudera.org:8080/8565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
Gerrit-Change-Number: 8565
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Nov 2017 22:48:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] dist test: enable sharding of a few more tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has removed a vote on this change.
Change subject: dist_test: enable sharding of a few more tests
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iff1e0ac39f1834e8ac22283e1dc0c336d328ae35
Gerrit-Change-Number: 8565
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>