You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "dmvk (via GitHub)" <gi...@apache.org> on 2023/04/04 15:29:22 UTC
[GitHub] [flink] dmvk opened a new pull request, #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
dmvk opened a new pull request, #22350:
URL: https://github.com/apache/flink/pull/22350
https://issues.apache.org/jira/browse/FLINK-31471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158131292
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
+ JobManagerOptions.SchedulerType.Adaptive.equals(
Review Comment:
Please use ClusterOptions#isAdaptiveSchedulerEnabled and ClusterOptions#isReactiveModeEnabled.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
Review Comment:
Note: This may not work as we'd like it to. If the user has configured the adaptive scheduler, but submits a batch job, then the buttons will still be shown.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
+ JobManagerOptions.SchedulerType.Adaptive.equals(
+ configuration.get(JobManagerOptions.SCHEDULER))
+ && configuration.get(JobManagerOptions.SCHEDULER_MODE) == null;
+ final boolean webRescaleEnabled =
Review Comment:
Do we want this option to be purely for the UI or also for the REST API as a whole? If the latter, then we could also disable the requirement handlers directly in the endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158284092
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
Review Comment:
This is doubly unfortunate since I originally expected this to work such that we could disable the handlers, preventing calls to the requirement APIs if the DefaultScheduler is used.
Due to that I removed the handling of UnsupportedOperationExceptions from the JobMaster.
:facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on PR #22350:
URL: https://github.com/apache/flink/pull/22350#issuecomment-1504891422
@zentol The error handling is now fixed if you want to try it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158525700
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
Review Comment:
https://issues.apache.org/jira/browse/FLINK-31737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158148645
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
Review Comment:
Hmm, that's a good point; I'm wondering if there's anything we can do about it since this is a cluster-wide configuration. Maybe we can check the UI level for `webRescaleSupported && job.isStreaming()`? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1163896475
##########
flink-runtime-web/web-dashboard/src/app/app.interceptor.ts:
##########
@@ -62,10 +65,8 @@ export class AppInterceptor implements HttpInterceptor {
ignoreErrorUrlEndsList.every(url => !res.url.endsWith(url)) &&
ignoreErrorMessage.every(message => errorMessage !== message)
) {
- this.injector.get<StatusService>(StatusService).listOfErrorMessage.push(errorMessage);
- this.injector
- .get<NzNotificationService>(NzNotificationService)
- .info('Server Response Message:', errorMessage.replaceAll(' at ', '\n at '), option);
+ this.statusService.listOfErrorMessage.push(errorMessage);
+ this.notificationService.info('Server Response Message:', errorMessage.replaceAll(' at ', '\n at '), option);
Review Comment:
So was this just completely broken, or...?
(if so, something to backport to 1.17?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on PR #22350:
URL: https://github.com/apache/flink/pull/22350#issuecomment-1497623195
Thanks for the review Chesnay, I've addressed the comments and scheduled some follow-ups. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on PR #22350:
URL: https://github.com/apache/flink/pull/22350#issuecomment-1498732106
> WDYT? I can, of course, try to pull something off, but there is certainly a limit on how good I can make this.
That plan sounds fine to me. Let's file tickets for the issues I've listed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158280277
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
+ JobManagerOptions.SchedulerType.Adaptive.equals(
+ configuration.get(JobManagerOptions.SCHEDULER))
+ && configuration.get(JobManagerOptions.SCHEDULER_MODE) == null;
+ final boolean webRescaleEnabled =
Review Comment:
`web.submit.enable` can also disable the jar handlers :sweat_smile:
I don't really like having 1 option for both the UI and REST API.
If we want to allow users to disable this, then I'd prefer a separate rest option (that would then also potentially disable the UI option).
Not sure if we need that though in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158284092
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
Review Comment:
This is doubly unfortunate since I originally expected this to work such that we could disable the handlers, preventing calls to the requirement APIs if the DefaultScheduler is used.
Due to that the JobMaster isn't no longer handling UnsupportedOperationExceptions.
:facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158357130
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
Review Comment:
> If the user has configured the adaptive scheduler, but submits a batch job, then the buttons will still be shown.
let's take this as a limitation for now, and I'll create a follow up ticket to address this as the fix allows tweaking JobDetails rest API endpoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1165606301
##########
flink-runtime-web/web-dashboard/src/app/app.interceptor.ts:
##########
@@ -62,10 +65,8 @@ export class AppInterceptor implements HttpInterceptor {
ignoreErrorUrlEndsList.every(url => !res.url.endsWith(url)) &&
ignoreErrorMessage.every(message => errorMessage !== message)
) {
- this.injector.get<StatusService>(StatusService).listOfErrorMessage.push(errorMessage);
- this.injector
- .get<NzNotificationService>(NzNotificationService)
- .info('Server Response Message:', errorMessage.replaceAll(' at ', '\n at '), option);
+ this.statusService.listOfErrorMessage.push(errorMessage);
+ this.notificationService.info('Server Response Message:', errorMessage.replaceAll(' at ', '\n at '), option);
Review Comment:
backported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk merged pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk merged PR #22350:
URL: https://github.com/apache/flink/pull/22350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1163947108
##########
flink-runtime-web/web-dashboard/src/app/app.interceptor.ts:
##########
@@ -62,10 +65,8 @@ export class AppInterceptor implements HttpInterceptor {
ignoreErrorUrlEndsList.every(url => !res.url.endsWith(url)) &&
ignoreErrorMessage.every(message => errorMessage !== message)
) {
- this.injector.get<StatusService>(StatusService).listOfErrorMessage.push(errorMessage);
- this.injector
- .get<NzNotificationService>(NzNotificationService)
- .info('Server Response Message:', errorMessage.replaceAll(' at ', '\n at '), option);
+ this.statusService.listOfErrorMessage.push(errorMessage);
+ this.notificationService.info('Server Response Message:', errorMessage.replaceAll(' at ', '\n at '), option);
Review Comment:
the problem was that we were not able to resolve notification service; this just makes the problem more visible, because it needs to be resolved at the construction time
the actual fix is in `main.ts`:
```
importProvidersFrom(NzNotificationModule),
```
let me try if we have the same issue in 1.17 .. this might have been broken at any point since we don't have regression tests for UI :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on PR #22350:
URL: https://github.com/apache/flink/pull/22350#issuecomment-1505048980
> (well, if "properly" includes a giant pointless stack trace 🤷)
yeah, it's not optimal 😢 that's a different issue to address though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158445558
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
+ JobManagerOptions.SchedulerType.Adaptive.equals(
+ configuration.get(JobManagerOptions.SCHEDULER))
+ && configuration.get(JobManagerOptions.SCHEDULER_MODE) == null;
+ final boolean webRescaleEnabled =
Review Comment:
For now, I'd leave it as is (just a UI option) and develop a systematic solution to align this across all three options (submit, cancel, rescale). Otherwise, it will create more confusion.
https://issues.apache.org/jira/browse/FLINK-31734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on PR #22350:
URL: https://github.com/apache/flink/pull/22350#issuecomment-1497788210
For the UX comments: I'm not a UX person, and this is good enough for the demo purpose (it was not meant for serious usage, that's what REST API is for). We touched on this a few weeks back with @knaufk, and the plan is to reach out to the ML with the demo and see if any UX-proficient person volunteers to improve this.
WDYT? I can, of course, try to pull something off, but there is certainly a limit on how good I can make this.
> errors about exceeding max parallelism are not reported to the user or handled by the UI
👍 I'll look into that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22350:
URL: https://github.com/apache/flink/pull/22350#issuecomment-1496190730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e04d9eac0868dc0b940bdcd7f5bba54788cd96c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e04d9eac0868dc0b940bdcd7f5bba54788cd96c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e04d9eac0868dc0b940bdcd7f5bba54788cd96c0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158276777
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
Review Comment:
Do we expose batch/streaming type in the REST API somewhere? I couldn't find that.
long-term we may want to add a per-job config handler, that could report whether checkpoints/rescaling/whatever job-specific thing is supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158147075
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
+ JobManagerOptions.SchedulerType.Adaptive.equals(
+ configuration.get(JobManagerOptions.SCHEDULER))
+ && configuration.get(JobManagerOptions.SCHEDULER_MODE) == null;
+ final boolean webRescaleEnabled =
Review Comment:
I was looking at the job cancellation (webCancelEnabled), and that doesn't seem to be the case for it. If this is correct, should we leave it as is and create a follow to implement this for all "web UI mutability features"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chachae commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.
Posted by "chachae (via GitHub)" <gi...@apache.org>.
chachae commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1225699824
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,19 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
+ ClusterOptions.isAdaptiveSchedulerEnabled(configuration)
+ && !ClusterOptions.isReactiveModeEnabled(configuration);
Review Comment:
Why cannot change the parallelism of a job running in reactive mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org