You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Aleksandar Vidakovic (Jira)" <ji...@apache.org> on 2020/10/12 19:30:00 UTC

[jira] [Reopened] (FINERACT-1188) README and other files are not covered by Spotless

     [ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksandar Vidakovic reopened FINERACT-1188:
--------------------------------------------

Tried to do this from scratch, because the existing PR created too many conflicts on rebase. There is still an issue remaining on integrationTest ("connection refused", not sure if that is related to my changes, but locally the Docker container is running just fine).

The new approach reveals even more issues with the plugin configs; moving just Spotless to the top-level didn't work as expected.

Concentrating on other stuff in the meanwhile until I get a better idea how a step by step implementation approach to cleanup build.gradle can work.

> README and other files are not covered by Spotless
> --------------------------------------------------
>
>                 Key: FINERACT-1188
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1188
>             Project: Apache Fineract
>          Issue Type: Sub-task
>            Reporter: Michael Vorburger
>            Assignee: Aleksandar Vidakovic
>            Priority: Major
>
> Would it be possible to extract JUST the work related to make README and other files are covered by Spotless fromĀ [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, fineract-doc - is that possible?
> You could perhaps before that even make a PR #0 with JUST the trivial formatting changes itself which Spotbugs made once you change the layout, but without any build change - just send them first, separately - get that out of the way?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)