You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/08/26 18:13:04 UTC

[GitHub] [thrift] fishy opened a new pull request #2446: go: Fix things staticcheck complains about

fishy opened a new pull request #2446:
URL: https://github.com/apache/thrift/pull/2446


   Client: go
   
   Staticcheck is the recommended replacement of the frozen and deprecated
   official golint linter [1].
   
   Fix the things it complained about (or add lint:ignore directive) in:
   
   - lib/go/thrift
   - lib/go/test/tests
   - tutorial/go/src
   - test/go/src
   - compiler generated code
   
   The majority of the fixes are in the following categories:
   
   - Use of deprecated function (mainly the TConfiguration related ones)
   - Redundant break in swith cases
   
   Also in the same spirit as fb539ae, remove the error return from
   NewTSSLSocket as it can never be non-nil.
   
   This change will be cherry-picked into 0.15.0 branch after merged.
   
   [1]: https://groups.google.com/g/golang-nuts/c/rCP70Aq_tBc
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy merged pull request #2446: go: Fix things staticcheck complains about

Posted by GitBox <gi...@apache.org>.

fishy merged pull request #2446:
URL: https://github.com/apache/thrift/pull/2446


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org