You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/03/28 16:46:19 UTC

[GitHub] [dubbo] codecov-io commented on issue #5934: AdaptiveCodeGenerateand InjvmProtocol code refactor

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5934?src=pr&el=h1) Report
> Merging [#5934](https://codecov.io/gh/apache/dubbo/pull/5934?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/cefe7c37e9c31d478b2fe08f323c1f9542ca1466?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `95.23%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5934/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/5934?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #5934      +/-   ##
============================================
- Coverage     61.21%   61.17%   -0.04%     
  Complexity      494      494              
============================================
  Files           981      981              
  Lines         39106    39093      -13     
  Branches       5620     5617       -3     
============================================
- Hits          23939    23917      -22     
- Misses        12536    12545       +9     
  Partials       2631     2631
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5934?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...o/common/extension/AdaptiveClassCodeGenerator.java](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0FkYXB0aXZlQ2xhc3NDb2RlR2VuZXJhdG9yLmphdmE=) | `100% <100%> (+7.14%)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1pbmp2bS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2luanZtL0luanZtUHJvdG9jb2wuamF2YQ==) | `81.08% <75%> (-1.28%)` | `0 <0> (ø)` | |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `58.68% <0%> (-2.96%)` | `0% <0%> (ø)` | |
| [...ache/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNsaWVudC5qYXZh) | `56.92% <0%> (-1.54%)` | `8% <0%> (-1%)` | |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `79.55% <0%> (-1.49%)` | `0% <0%> (ø)` | |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeURpcmVjdG9yeS5qYXZh) | `75.43% <0%> (-0.87%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `78.44% <0%> (-0.87%)` | `0% <0%> (ø)` | |
| [...o/rpc/cluster/support/MergeableClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9NZXJnZWFibGVDbHVzdGVySW52b2tlci5qYXZh) | `40% <0%> (-0.66%)` | `0% <0%> (ø)` | |
| [...g/apache/dubbo/registry/consul/ConsulRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktY29uc3VsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jb25zdWwvQ29uc3VsUmVnaXN0cnkuamF2YQ==) | `62.11% <0%> (-0.63%)` | `30% <0%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/dubbo/pull/5934/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5934?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5934?src=pr&el=footer). Last update [cefe7c3...3a98b1c](https://codecov.io/gh/apache/dubbo/pull/5934?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/5934 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org