You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "datbth (via GitHub)" <gi...@apache.org> on 2024/09/21 07:46:06 UTC
[PR] wip [arrow]
datbth opened a new pull request, #44179:
URL: https://github.com/apache/arrow/pull/44179
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
GH-44178: [GLib][Ruby][Flight] allow setting CallOption timeout
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] wip [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44179:
URL: https://github.com/apache/arrow/pull/44179#issuecomment-2365047933
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44178: [GLib][Ruby][Flight] Allow setting CallOption timeout [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44179:
URL: https://github.com/apache/arrow/pull/44179#issuecomment-2366829155
GH-44181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44178: [GLib][Ruby][Flight] Allow setting CallOption timeout [arrow]
Posted by "datbth (via GitHub)" <gi...@apache.org>.
datbth commented on PR #44179:
URL: https://github.com/apache/arrow/pull/44179#issuecomment-2365422452
Many thanks for commenting, @kou.
Yes please work on this per your convenience. Thank you!
Indeed I'm not familiar with GObject introspection.
Besides, I'm not a C++ developer so I'm actually still have troubles setting up my dev environment (currently around building/linking the local build of arrow 18). I wonder if there is a Slack/Discord where I can bother and learn more from you guys lol.
I'm only trying out in my spare time so it very likely will take much longer for me to complete this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44178: [GLib][Ruby][Flight] Allow setting CallOption timeout [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44179:
URL: https://github.com/apache/arrow/pull/44179#issuecomment-2365337077
:warning: GitHub issue #44178 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44178: [GLib][Ruby][Flight] Allow setting CallOption timeout [arrow]
Posted by "datbth (via GitHub)" <gi...@apache.org>.
datbth closed pull request #44179: GH-44178: [GLib][Ruby][Flight] Allow setting CallOption timeout
URL: https://github.com/apache/arrow/pull/44179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44178: [GLib][Ruby][Flight] Allow setting CallOption timeout [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44179:
URL: https://github.com/apache/arrow/pull/44179#issuecomment-2365621601
OK. I'll open a PR for this later.
How about using https://ursalabs.zulipchat.com/ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44178: [GLib][Ruby][Flight] Allow setting CallOption timeout [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44179:
URL: https://github.com/apache/arrow/pull/44179#discussion_r1769663320
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -294,6 +294,23 @@ gaflight_call_options_foreach_header(GAFlightCallOptions *options,
}
}
+/**
+ * gaflight_call_options_set_timeout:
+ * @options: A #GAFlightCallOptions.
+ * @value: The timeout value (in seconds).
+ *
+ * Set the timeout (in seconds).
+ *
+ * Since: 18.0.0
+ */
+void
+gaflight_call_options_set_timeout(GAFlightCallOptions *options,
+ const gint64 *value)
Review Comment:
```suggestion
gdouble timeout)
```
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -294,6 +294,23 @@ gaflight_call_options_foreach_header(GAFlightCallOptions *options,
}
}
+/**
+ * gaflight_call_options_set_timeout:
+ * @options: A #GAFlightCallOptions.
+ * @value: The timeout value (in seconds).
+ *
+ * Set the timeout (in seconds).
Review Comment:
```suggestion
* Set the timeout in seconds.
*
* An optional timeout for this call. Negative durations
* mean an implementation-defined default behavior will be used
* instead. This is the default value.
```
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -294,6 +294,23 @@ gaflight_call_options_foreach_header(GAFlightCallOptions *options,
}
}
+/**
+ * gaflight_call_options_set_timeout:
+ * @options: A #GAFlightCallOptions.
+ * @value: The timeout value (in seconds).
Review Comment:
```suggestion
* @timeout: The timeout in seconds.
```
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -294,6 +294,23 @@ gaflight_call_options_foreach_header(GAFlightCallOptions *options,
}
}
+/**
+ * gaflight_call_options_set_timeout:
+ * @options: A #GAFlightCallOptions.
+ * @value: The timeout value (in seconds).
+ *
+ * Set the timeout (in seconds).
+ *
+ * Since: 18.0.0
+ */
+void
+gaflight_call_options_set_timeout(GAFlightCallOptions *options,
+ const gint64 *value)
+{
+ auto flight_options = gaflight_call_options_get_raw(options);
+ flight_options->timeout = arrow::flight::TimeoutDuration(*value);
Review Comment:
```suggestion
flight_options->timeout = arrow::flight::TimeoutDuration(timeout);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org