[GitHub] [airflow] eladkal commented on issue #7880: Don't schedule dummy task

[GitBox <gi...@apache.org>]

eladkal commented on issue #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880#issuecomment-604309597
 
 
   I think it's a good idea that `DummyOperator` won't be scheduled but I don't agree with the statement "DummyOperator doesn't actually do work".
   
   For example:
   If the Dummy is marked always as success what will happen to cases where `DummyOperator` is used with trigger rules for some flows ?
   
   Example:
   ```
   final = DummyOperator(
                                 dag=dag,
                                 task_id="error_check",
                                 trigger_rule=TriggerRule.ONE_FAILED
                               )
   [task1, task2, task3] >> final
   ```
   
   In this case marking `final` as `FAILED` result in failure of the DAG which invoke `on_failure_callback`.
   
   Also it's possible in the above example that there is ExternalSensor from `dag2` on `final` so it's important that `final` won't be marked as `SUCCESS` automatically.
   
   
   Probably just need to update `Updating.md` alerting change of behavior as  DummyOperator will not longer honor `trigger_rule`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services