[GitHub] [spark] MaxGekk commented on a diff in pull request #38514: [SPARK-41019][SQL] Provide a query context to `failAnalysis()`

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #38514:
URL: https://github.com/apache/spark/pull/38514#discussion_r1014643347


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -82,24 +82,24 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
 
   private def checkLimitLikeClause(name: String, limitExpr: Expression): Unit = {
     limitExpr match {
-      case e if !e.foldable => failAnalysis(
+      case e if !e.foldable => limitExpr.failAnalysis(

Review Comment:
   I would use it but the type `Expression` of `limitExpr` is enough to invoke `failAnalysis` here. I can replace `limitExpr` by `e` when I will address other comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org