[GitHub] srowen commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance spark-submit for app management

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance spark-submit for app management
URL: https://github.com/apache/spark/pull/23599#discussion_r254712557
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
 ##########
 @@ -304,18 +304,20 @@ private[deploy] class SparkSubmitArguments(args: Seq[String], env: Map[String, S
   }
 
   private def validateKillArguments(): Unit = {
-    if (!master.startsWith("spark://") && !master.startsWith("mesos://")) {
-      error("Killing submissions is only supported in standalone or Mesos mode!")
+    if (!master.startsWith("spark://") && !master.startsWith("mesos://")
+      && !master.startsWith("k8s://")) {
+      error("Killing submissions is only supported in standalone, Mesos or K8s mode!")
     }
     if (submissionToKill == null) {
       error("Please specify a submission to kill.")
     }
   }
 
   private def validateStatusRequestArguments(): Unit = {
-    if (!master.startsWith("spark://") && !master.startsWith("mesos://")) {
+    if (!master.startsWith("spark://") && !master.startsWith("mesos://") &&
 
 Review comment:
   You could maybe refactor the check into a small private method to avoid duplication, but no big deal

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org