You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/07/28 12:48:30 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #504: Update sbt-reproducible-builds and set check resolver to staging
mdedetrich opened a new pull request, #504:
URL: https://github.com/apache/incubator-pekko/pull/504
So its easier to verify future builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #504: Update sbt-reproducible-builds and set check resolver to staging
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #504:
URL: https://github.com/apache/incubator-pekko/pull/504#discussion_r1277510763
##########
build.sbt:
##########
@@ -24,6 +25,9 @@ commands := commands.value.filterNot { command =>
}
}
+ThisBuild / reproducibleBuildsCheckResolver :=
+ "Apache Pekko Staging".at("https://repository.apache.org/content/groups/staging/")
Review Comment:
I was planning to document this in our [release process](https://github.com/apache/incubator-pekko-site/wiki/Pekko-Release-Process). This makes sense as a default because almost all of the time the use case is to verify against jars in staging, if something has already been released and it wasn't picked up in staging then something went wrong.
And do note that modifying the source dirty's the repo which creates surprising results that we have experienced in the past few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #504: Update sbt-reproducible-builds and set check resolver to staging
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #504:
URL: https://github.com/apache/incubator-pekko/pull/504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #504: Update sbt-reproducible-builds and set check resolver to staging
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #504:
URL: https://github.com/apache/incubator-pekko/pull/504#discussion_r1277510763
##########
build.sbt:
##########
@@ -24,6 +25,9 @@ commands := commands.value.filterNot { command =>
}
}
+ThisBuild / reproducibleBuildsCheckResolver :=
+ "Apache Pekko Staging".at("https://repository.apache.org/content/groups/staging/")
Review Comment:
I was planning to document this in our [release process](https://github.com/apache/incubator-pekko-site/wiki/Pekko-Release-Process). This makes sense as a default because almost all of the time the use case is to verify against jars in staging, if something has already been released and its not in staging then something went wrong.
And do note that modifying the source dirty's the repo which creates surprising results that we have experienced in the past few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #504: Update sbt-reproducible-builds and set check resolver to staging
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #504:
URL: https://github.com/apache/incubator-pekko/pull/504#discussion_r1277510763
##########
build.sbt:
##########
@@ -24,6 +25,9 @@ commands := commands.value.filterNot { command =>
}
}
+ThisBuild / reproducibleBuildsCheckResolver :=
+ "Apache Pekko Staging".at("https://repository.apache.org/content/groups/staging/")
Review Comment:
I was planning to document this in our [release process](https://github.com/apache/incubator-pekko-site/wiki/Pekko-Release-Process). This makes sense as a default because almost all of the time the use case is to verify against jars in staging, if something has already been released and its not in staging then something went wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #504: Update sbt-reproducible-builds and set check resolver to staging
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #504:
URL: https://github.com/apache/incubator-pekko/pull/504#discussion_r1277509158
##########
build.sbt:
##########
@@ -24,6 +25,9 @@ commands := commands.value.filterNot { command =>
}
}
+ThisBuild / reproducibleBuildsCheckResolver :=
+ "Apache Pekko Staging".at("https://repository.apache.org/content/groups/staging/")
Review Comment:
I understand that this useful but users might want to verify against maven central or some other repo. Would it be possible to add a comment about other possible repo values - possibly a link to some centralised doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org