You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2019/12/11 01:24:20 UTC
[kudu-CR] [python] Bump Cython version
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14883
to review the following change.
Change subject: [python] Bump Cython version
......................................................................
[python] Bump Cython version
Build with Cython 0.25.2 fails on Python 3.7.5, 0.27.2 fails with a
different error.
In some other project the fix was to upgrade to 0.29.2 which worked, but
decided to use latest 0.29 as there are lots of bug fixes which may or
may not be useful.
Change-Id: Ida81e06917c0f12619fe53764026bc1764027e22
---
M python/requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/14883/1
--
To view, visit http://gerrit.cloudera.org:8080/14883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida81e06917c0f12619fe53764026bc1764027e22
Gerrit-Change-Number: 14883
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] [python] Bump Cython version
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14883 )
Change subject: [python] Bump Cython version
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida81e06917c0f12619fe53764026bc1764027e22
Gerrit-Change-Number: 14883
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Dec 2019 18:41:03 +0000
Gerrit-HasComments: No
[kudu-CR] [python] Bump Cython version
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14883 )
Change subject: [python] Bump Cython version
......................................................................
Patch Set 1: Code-Review+2
Rebase on top of my earlier fix.
--
To view, visit http://gerrit.cloudera.org:8080/14883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida81e06917c0f12619fe53764026bc1764027e22
Gerrit-Change-Number: 14883
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Dec 2019 04:58:43 +0000
Gerrit-HasComments: No
[kudu-CR] [python] Bump Cython version
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14883 )
Change subject: [python] Bump Cython version
......................................................................
[python] Bump Cython version
Build with Cython 0.25.2 fails on Python 3.7.5, 0.27.2 fails with a
different error.
In some other project the fix was to upgrade to 0.29.2 which worked, but
decided to use latest 0.29 as there are lots of bug fixes which may or
may not be useful.
Change-Id: Ida81e06917c0f12619fe53764026bc1764027e22
Reviewed-on: http://gerrit.cloudera.org:8080/14883
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M python/requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida81e06917c0f12619fe53764026bc1764027e22
Gerrit-Change-Number: 14883
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] Bump Cython version
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14883 )
Change subject: [python] Bump Cython version
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida81e06917c0f12619fe53764026bc1764027e22
Gerrit-Change-Number: 14883
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Dec 2019 05:05:30 +0000
Gerrit-HasComments: No