You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/12/12 13:03:50 UTC
[PR] [WIP][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
MaxGekk opened a new pull request, #44314:
URL: https://github.com/apache/spark/pull/44314
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #44314:
URL: https://github.com/apache/spark/pull/44314#issuecomment-1852614913
> For my understanding, the following minor PR was the actual foundation of this PR, right?
Before this PR and https://github.com/apache/spark/pull/44311, we had only those exceptions that accept a message and don't require an error class:
- NonEmptyNamespaceException
- UnresolvedException
- ExtendedAnalysisException
The two PRs close the hole.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #44314:
URL: https://github.com/apache/spark/pull/44314#discussion_r1424985777
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -6958,6 +6958,21 @@
"<message>"
]
},
+ "_LEGACY_ERROR_TEMP_3101" : {
+ "message" : [
+ "The input is not a correct window column: <windowTime>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3102" : {
Review Comment:
There are already 5 error message templates: _LEGACY_ERROR_TEMP_3064, _LEGACY_ERROR_TEMP_3066, _LEGACY_ERROR_TEMP_3071, _LEGACY_ERROR_TEMP_3072, _LEGACY_ERROR_TEMP_3080, which are as
```
"message" : [
"<msg>"
]
```
...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44314:
URL: https://github.com/apache/spark/pull/44314#discussion_r1424440273
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -2638,10 +2638,14 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
test("SPARK-20164: ExtendedAnalysisException should be tolerant to null query plan") {
try {
- throw new ExtendedAnalysisException("", None, None, plan = null)
+ throw new ExtendedAnalysisException(
+ new AnalysisException(
+ errorClass = "_LEGACY_ERROR_USER_RAISED_EXCEPTION",
Review Comment:
The error class doesn't matter in the test. I just took some valid class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44314:
URL: https://github.com/apache/spark/pull/44314#discussion_r1425057292
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -2638,10 +2638,14 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
test("SPARK-20164: ExtendedAnalysisException should be tolerant to null query plan") {
try {
- throw new ExtendedAnalysisException("", None, None, plan = null)
+ throw new ExtendedAnalysisException(
+ new AnalysisException(
+ errorClass = "_LEGACY_ERROR_USER_RAISED_EXCEPTION",
+ messageParameters = Map("errorMessage" -> "null query plan")),
+ plan = null)
} catch {
case ae: ExtendedAnalysisException =>
- assert(ae.plan == null && ae.getMessage == ae.getSimpleMessage)
+ assert(ae.plan == None && ae.getMessage == ae.getSimpleMessage)
Review Comment:
`isEmpty` is better probably. I will change this when I will address other comments in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #44314:
URL: https://github.com/apache/spark/pull/44314#discussion_r1425014395
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -2638,10 +2638,14 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
test("SPARK-20164: ExtendedAnalysisException should be tolerant to null query plan") {
try {
- throw new ExtendedAnalysisException("", None, None, plan = null)
+ throw new ExtendedAnalysisException(
+ new AnalysisException(
+ errorClass = "_LEGACY_ERROR_USER_RAISED_EXCEPTION",
+ messageParameters = Map("errorMessage" -> "null query plan")),
+ plan = null)
} catch {
case ae: ExtendedAnalysisException =>
- assert(ae.plan == null && ae.getMessage == ae.getSimpleMessage)
+ assert(ae.plan == None && ae.getMessage == ae.getSimpleMessage)
Review Comment:
Which is better, `ae.plan == None` or `ae.plan.isEmpty`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #44314:
URL: https://github.com/apache/spark/pull/44314#discussion_r1425017792
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -6958,6 +6958,21 @@
"<message>"
]
},
+ "_LEGACY_ERROR_TEMP_3101" : {
+ "message" : [
+ "The input is not a correct window column: <windowTime>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3102" : {
Review Comment:
OK ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #44314:
URL: https://github.com/apache/spark/pull/44314#issuecomment-1853434726
@dongjoon-hyun @beliefer @LuciferYang @cloud-fan Any objections for the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44314:
URL: https://github.com/apache/spark/pull/44314#discussion_r1425013082
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -6958,6 +6958,21 @@
"<message>"
]
},
+ "_LEGACY_ERROR_TEMP_3101" : {
+ "message" : [
+ "The input is not a correct window column: <windowTime>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_3102" : {
Review Comment:
We cannot merge them because those are different kind of errors. Later we should improve them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #44314:
URL: https://github.com/apache/spark/pull/44314#issuecomment-1853556367
Merging to master. Thank you, @srielau @LuciferYang @dongjoon-hyun for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #44314:
URL: https://github.com/apache/spark/pull/44314#issuecomment-1852572628
@cloud-fan @dongjoon-hyun @LuciferYang @beliefer @srielau Could you review this PR, please. After this PR all `AnalysisException ` and its sub-classes will be migrated onto error classes. So, will be not possible to raise such exceptions w/ providing any error class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #44314:
URL: https://github.com/apache/spark/pull/44314#discussion_r1424416253
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -2638,10 +2638,14 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
test("SPARK-20164: ExtendedAnalysisException should be tolerant to null query plan") {
try {
- throw new ExtendedAnalysisException("", None, None, plan = null)
+ throw new ExtendedAnalysisException(
+ new AnalysisException(
+ errorClass = "_LEGACY_ERROR_USER_RAISED_EXCEPTION",
Review Comment:
This error class is meant as a fallback for raise_error().
Why do you pick it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #44314: [SPARK-46381][SQL] Migrate sub-classes of `AnalysisException` to error classes
URL: https://github.com/apache/spark/pull/44314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org