[jira] [Commented] (BOOKKEEPER-578) LedgerCacheImpl is reserving 1/3 of Heap size but allocates NonHeap memory

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225775#comment-15225775 ] 

ASF GitHub Bot commented on BOOKKEEPER-578:
-------------------------------------------

Github user sijie commented on the pull request:

    https://github.com/apache/bookkeeper/pull/28#issuecomment-205678610
  
    the change looks good to me. +1


> LedgerCacheImpl is reserving 1/3 of Heap size but allocates NonHeap memory
> --------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-578
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-578
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>            Reporter: Matteo Merli
>            Assignee: Matteo Merli
>            Priority: Minor
>             Fix For: 4.4.0
>
>
> By default the page limit parameter is set to -1, which means to assign 1/3 of Heap space to the LedgerCache. Each LedgerEntryPage is then allocating the memory outside the heap (ByteBuffer.allocateDirect()).
> This makes BK to use more memory than the -XmxNN configured setting. Is there any particular reason for the LedgerEntryPage buffer to be allocated outside the java heap? Could that be changed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)