[GitHub] [incubator-kyuubi] bowenliang123 commented on a diff in pull request #3380: [KYUUBI #3371] [FEATURE] [AUTHZ] Support checking access privileges in single call and throws all disallowed in exception

[GitBox <gi...@apache.org>]

bowenliang123 commented on code in PR #3380:
URL: https://github.com/apache/incubator-kyuubi/pull/3380#discussion_r960486360


##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/SparkRangerAdminPlugin.scala:
##########
@@ -76,4 +94,38 @@ object SparkRangerAdminPlugin extends RangerBasePlugin("spark", "sparkSql") {
     val digits = s"regexp_replace($lower, '[0-9]', 'n'$pos)"
     digits
   }
+
+  @throws[AccessControlException]
+  def verify(
+      requests: util.List[RangerAccessRequest],

Review Comment:
   When with imported ` java.util.List`, a format warning is shown by IDEA. Does it matter?
   <img width="418" alt="image" src="https://user-images.githubusercontent.com/1935105/187893801-6b5b6674-af83-4fe4-b210-3dbd3fb9f6c9.png">
   
   If autofix by IDEA with prefix, falling back to `util.List`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org