[jira] [Commented] (CALCITE-5931) Fix integral number detection

["Jiajun Xie (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756248#comment-17756248 ] 

Jiajun Xie commented on CALCITE-5931:
-------------------------------------

[~cbrisson] Thank you for your commit, but we can do even better in something.

 
 # We don't like messages starting with Fix. Maybe we can use `Allow integers like 1.00 in window frame`.
 # Unit Test can make PR more popular, so you can write some cases

 ## 0.00
 ## 1.00
 ## Double.MAX_VALUE

> Fix integral number detection
> -----------------------------
>
>                 Key: CALCITE-5931
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5931
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.35.0
>            Reporter: Claude Brisson
>            Priority: Minor
>              Labels: pull-request-available
>
> When a number of rows is specified for a window, the code checks that the provided literal is an integral number.
> But the provided check leaves aside numbers like "1.00" (with a scale of 2, but with trailing zeros).
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)