You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/10 18:07:34 UTC
[GitHub] [incubator-yunikorn-core] steinsgateted opened a new pull request #385: [YUNIKORN-998] expose gang related info in application REST info
steinsgateted opened a new pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385
### What is this PR for?
expose gang related info in REST
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-998
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1075103634
Thank you for the explanation. I used this step [doc](https://yunikorn.apache.org/docs/developer_guide/deployment) to run YK. Not using helm.
Thanks. It works fine after using helm deploy YK.
```
"placeholderData":[
{
"taskGroupName":"spark-executor23971",
"count":4,
"minResource":{
"memory":1073741824,
"vcore":1000
},
"requiredNode":"",
"replaced":4
},
{
"taskGroupName":"spark-driver23971",
"count":1,
"minResource":{
"memory":1073741824,
"vcore":1000
},
"requiredNode":"",
"replaced":1
}
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] pbacsko edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
pbacsko edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1074984960
> @pbacsko could this be an issue with the changes from YUNIKORN-638:
>
> > ```
> > 2022-03-21T14:29:51.304Z ERROR cache/placeholder_manager.go:88 failed to create placeholder pod {"error": "Pod \"tg-spark-driver12324538-spark-a8949f51c61541909b1428-0\" is invalid: spec.containers[0].image: Required value"}
> > github.com/apache/incubator-yunikorn-k8shim/pkg/cache.(*PlaceholderManager).createAppPlaceholders
> > /home/ted/Desktop/younikon/998/incubator-yunikorn-k8shim/pkg/cache/placeholder_manager.go:88
> > ```
Yeah, but I'm not sure how. Is it coming from a running YK instance? Or an e2e test, unit test?
It's interesting because when we parse the flags, we use default values in the code, which is the usual "k8s.gcr.io/pause". Perhaps somehow an empty value was passed to the cmd line switch, like `--placeholderImage=` and `{$PLACEHOLDER_IMAGE}` was undefined. That can possibly happen if YK was not deployed with helm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#discussion_r829693806
##########
File path: pkg/webservice/handlers.go
##########
@@ -289,7 +292,18 @@ func getApplicationJSON(app *objects.Application) *dao.ApplicationDAOInfo {
ApplicationID: alloc.ApplicationID,
Partition: alloc.PartitionName,
}
- allocationInfos = append(allocationInfos, allocInfo)
+ allocationInfo = append(allocationInfo, allocInfo)
+ }
+
+ for _, taskGroup := range placeholders {
+ phInfo := dao.PlaceholderDAOInfo{
+ TaskGroupName: taskGroup.TaskGroupName,
Review comment:
Need a test to cover this
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -892,6 +903,10 @@ func (sa *Application) tryPlaceholderAllocate(nodeIterator func() NodeIterator,
alloc.Result = Replaced
// mark placeholder as released
ph.released = true
+ // store number of palceHolders that have been replaced so far
+ if sa.placeholderData != nil {
+ sa.placeholderData[ph.taskGroupName].Replaced++
+ }
Review comment:
I think a better point is the real replacement: `ReplaceAllocation()`
After the check for a duplicate message. That means the placeholder is really replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a3b0f4) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/b0906e9f24cdaedfc0777a1340685be732afb92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0906e9) will **decrease** coverage by `0.13%`.
> The diff coverage is `77.92%`.
> :exclamation: Current head 0a3b0f4 differs from pull request most recent head 822bfb9. Consider uploading reports for the commit 822bfb9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.52% 69.38% -0.14%
==========================================
Files 67 66 -1
Lines 9522 9516 -6
==========================================
- Hits 6620 6603 -17
- Misses 2657 2668 +11
Partials 245 245
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `74.20% <0.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <57.14%> (-1.07%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.43% <66.66%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.52% <85.71%> (+0.67%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `82.11% <100.00%> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.65% <100.00%> (-0.08%)` | :arrow_down: |
| [pkg/scheduler/placement/placement.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcGxhY2VtZW50Lmdv) | `83.33% <100.00%> (ø)` | |
| [pkg/common/resources/quantity.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZXMvcXVhbnRpdHkuZ28=) | | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0906e9...822bfb9](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d21f4c) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.08%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 4d21f4c differs from pull request most recent head 622baa3. Consider uploading reports for the commit 622baa3 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.31% -0.09%
==========================================
Files 66 66
Lines 9475 9511 +36
==========================================
+ Hits 6576 6593 +17
- Misses 2655 2673 +18
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.33% <0.00%> (-0.10%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.49% <23.52%> (-1.33%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.18% <77.77%> (+0.32%)` | :arrow_up: |
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `97.22% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...622baa3](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ba8dd4) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.03%`.
> The diff coverage is `77.63%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.36% -0.04%
==========================================
Files 66 66
Lines 9475 9516 +41
==========================================
+ Hits 6576 6601 +25
- Misses 2655 2669 +14
- Partials 244 246 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `74.20% <0.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <57.14%> (-0.97%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.43% <66.66%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.52% <85.71%> (+0.67%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `82.11% <100.00%> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.65% <100.00%> (ø)` | |
| [pkg/events/event\_publisher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2V2ZW50cy9ldmVudF9wdWJsaXNoZXIuZ28=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...1ba8dd4](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted commented on a change in pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on a change in pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#discussion_r831350399
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -892,6 +903,10 @@ func (sa *Application) tryPlaceholderAllocate(nodeIterator func() NodeIterator,
alloc.Result = Replaced
// mark placeholder as released
ph.released = true
+ // store number of palceHolders that have been replaced so far
+ if sa.placeholderData != nil {
+ sa.placeholderData[ph.taskGroupName].Replaced++
+ }
Review comment:
Thanks, move this code to the end of ReplaceAllocation().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d21f4c) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.08%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.31% -0.09%
==========================================
Files 66 66
Lines 9475 9511 +36
==========================================
+ Hits 6576 6593 +17
- Misses 2655 2673 +18
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.33% <0.00%> (-0.10%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.49% <23.52%> (-1.33%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.18% <77.77%> (+0.32%)` | :arrow_up: |
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `97.22% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...4d21f4c](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted commented on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064368052
Information displayed by REST:
```
"placeholderData":[
{
"taskGroupName":"spark-executor8090",
"count":4,
"minResource":{
"Resources":{
"memory":1074,
"vcore":1000
}
},
"requiredNode":"",
"replaced":0
},
{
"taskGroupName":"spark-driver8090",
"count":1,
"minResource":{
"Resources":{
"memory":1074,
"vcore":1000
}
},
"requiredNode":"",
"replaced":0
}
]
```
or
```
"placeholderData":[
{
"taskGroupName":"spark-executor8090",
"count":4,
"minResource":{
"Resources":{
"memory":1074,
"vcore":1000
}
},
"requiredNode":"",
"replaced":2
}
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e648485) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.01%`.
> The diff coverage is `77.33%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.38% -0.02%
==========================================
Files 66 66
Lines 9475 9516 +41
==========================================
+ Hits 6576 6603 +27
- Misses 2655 2668 +13
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `74.20% <0.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <55.00%> (-0.97%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.43% <66.66%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.52% <85.71%> (+0.67%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `82.11% <100.00%> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.65% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...e648485](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b55342) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.09%`.
> The diff coverage is `58.49%`.
> :exclamation: Current head 7b55342 differs from pull request most recent head e648485. Consider uploading reports for the commit e648485 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.30% -0.10%
==========================================
Files 66 66
Lines 9475 9516 +41
==========================================
+ Hits 6576 6595 +19
- Misses 2655 2676 +21
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.79% <57.14%> (-0.06%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <60.00%> (-0.97%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...e648485](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted commented on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1072096727
Thank you for the explanation.
Create [YUNIKORN-1138](https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1138) for datas and infos
Create [YUNIKORN-1137](https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1137) for placment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted commented on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1072096727
Thank you for the explanation.
Create [YUNIKORN-1138](https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1138) for datas and infos
Create [YUNIKORN-1137](https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1137) for placment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3b12f29) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/b0906e9f24cdaedfc0777a1340685be732afb92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0906e9) will **increase** coverage by `0.10%`.
> The diff coverage is `91.11%`.
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 69.52% 69.62% +0.10%
==========================================
Files 67 67
Lines 9522 9567 +45
==========================================
+ Hits 6620 6661 +41
- Misses 2657 2661 +4
Partials 245 245
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/allocation\_ask.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb25fYXNrLmdv) | `89.61% <0.00%> (-4.92%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.88% <100.00%> (+1.03%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `76.41% <100.00%> (+0.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0906e9...3b12f29](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted commented on a change in pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on a change in pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#discussion_r831354195
##########
File path: pkg/webservice/handlers.go
##########
@@ -289,7 +292,18 @@ func getApplicationJSON(app *objects.Application) *dao.ApplicationDAOInfo {
ApplicationID: alloc.ApplicationID,
Partition: alloc.PartitionName,
}
- allocationInfos = append(allocationInfos, allocInfo)
+ allocationInfo = append(allocationInfo, allocInfo)
+ }
+
+ for _, taskGroup := range placeholders {
+ phInfo := dao.PlaceholderDAOInfo{
+ TaskGroupName: taskGroup.TaskGroupName,
Review comment:
Thanks. Add a test in `handlers_test.go`. Add a `SetPendingAskRepeat` function in `allocation_ask.go`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted commented on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1075103634
Thank you for the explanation. I used this step [doc](https://yunikorn.apache.org/docs/developer_guide/deployment) to run YK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted commented on a change in pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on a change in pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#discussion_r831350399
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -892,6 +903,10 @@ func (sa *Application) tryPlaceholderAllocate(nodeIterator func() NodeIterator,
alloc.Result = Replaced
// mark placeholder as released
ph.released = true
+ // store number of palceHolders that have been replaced so far
+ if sa.placeholderData != nil {
+ sa.placeholderData[ph.taskGroupName].Replaced++
+ }
Review comment:
Thanks, move this code to the end of `ReplaceAllocation()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#discussion_r824274961
##########
File path: pkg/webservice/handlers.go
##########
@@ -290,6 +293,20 @@ func getApplicationJSON(app *objects.Application) *dao.ApplicationDAOInfo {
Partition: alloc.PartitionName,
}
allocationInfos = append(allocationInfos, allocInfo)
+ if alloc.IsPlaceholder() {
Review comment:
Something like this:
```
placeholders := app.GetPlaceholderData()
placeholderInfos := make([]dao.PlaceholderDAOInfo, 0, len(placeholders))
for _, taskGroup := range placeholders {
...
placeholderInfos = append(placeholderInfos, placeholderInfo)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c81a79b) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.12%`.
> The diff coverage is `57.40%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.27% -0.13%
==========================================
Files 66 66
Lines 9475 9517 +42
==========================================
+ Hits 6576 6593 +17
- Misses 2655 2678 +23
- Partials 244 246 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.74% <55.17%> (-0.11%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <60.00%> (-0.97%)` | :arrow_down: |
| [pkg/events/event\_publisher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2V2ZW50cy9ldmVudF9wdWJsaXNoZXIuZ28=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...c81a79b](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a3b0f4) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.01%`.
> The diff coverage is `77.92%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.38% -0.02%
==========================================
Files 66 66
Lines 9475 9516 +41
==========================================
+ Hits 6576 6603 +27
- Misses 2655 2668 +13
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `74.20% <0.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <57.14%> (-0.97%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.43% <66.66%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.52% <85.71%> (+0.67%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `82.11% <100.00%> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.65% <100.00%> (ø)` | |
| [pkg/scheduler/placement/placement.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcGxhY2VtZW50Lmdv) | `83.33% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...0a3b0f4](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064368052
Information displayed by REST:
```
"placeholderDatas":[
{
"taskGroupName":"spark-executor8090",
"count":4,
"minResource":{
"Resources":{
"memory":1074,
"vcore":1000
}
},
"requiredNode":"",
"replaced":0
},
{
"taskGroupName":"spark-driver8090",
"count":1,
"minResource":{
"Resources":{
"memory":1074,
"vcore":1000
}
},
"requiredNode":"",
"replaced":0
}
]
```
or
```
"placeholderDatas":[
{
"taskGroupName":"spark-executor8090",
"count":4,
"minResource":{
"Resources":{
"memory":1074,
"vcore":1000
}
},
"requiredNode":"",
"replaced":2
}
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#discussion_r824268872
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -1520,3 +1533,19 @@ func (sa *Application) GetRejectedMessage() string {
defer sa.RUnlock()
return sa.rejectedMessage
}
+
+func (sa *Application) SetPlaceholderData(taskGroupName string, minResource *resources.Resource, requiredNode string) {
Review comment:
This should be called as part of adding the ask in the application:
* unlocked function
* internal function (not exported)
We need an exported and locked `GetPlaceholdersData() []*PlaceholderData` to call from the web service like the `GetAllAllocations()` implementation
##########
File path: pkg/scheduler/objects/allocation.go
##########
@@ -159,6 +159,6 @@ func (a *Allocation) IsReleased() bool {
}
// getTaskGroup returns the task group name if set.
-func (a *Allocation) getTaskGroup() string {
+func (a *Allocation) GetTaskGroup() string {
Review comment:
Also update the comment when you export the function, however I don't think we need it at this point with the changed handler implementation proposed below
##########
File path: pkg/scheduler/context.go
##########
@@ -785,6 +785,8 @@ func (cc *ClusterContext) processAsks(request *si.AllocationRequest) {
zap.String("applicationID", siAsk.ApplicationID),
zap.String("askKey", siAsk.AllocationKey),
zap.Error(err))
+ } else if siAsk.Placeholder {
+ partition.applications[siAsk.ApplicationID].SetPlaceholderData(siAsk.TaskGroupName, resources.NewResourceFromProto(siAsk.ResourceAsk), common.GetRequiredNodeFromTag(siAsk.Tags))
Review comment:
This must be moved all the way down into the `app.AddAllocationAsk()` method.
##########
File path: pkg/webservice/handlers.go
##########
@@ -290,6 +293,20 @@ func getApplicationJSON(app *objects.Application) *dao.ApplicationDAOInfo {
Partition: alloc.PartitionName,
}
allocationInfos = append(allocationInfos, allocInfo)
+ if alloc.IsPlaceholder() {
Review comment:
This would add a lot of overhead: an application with 1000 placeholders in the same task group would do this 1000 times, it only needs to be done once.
The placeholder data we display is a top level object on the application, not one for each allocation
##########
File path: pkg/webservice/handlers.go
##########
@@ -277,6 +277,9 @@ func getPartitionJSON(partition *scheduler.PartitionContext) *dao.PartitionDAOIn
func getApplicationJSON(app *objects.Application) *dao.ApplicationDAOInfo {
allocations := app.GetAllAllocations()
allocationInfos := make([]dao.AllocationDAOInfo, 0, len(allocations))
+ placeholderInfos := make([]dao.PlaceholderDAOInfo, 0, len(app.PlaceholderDatas))
Review comment:
This needs to directly come from the application similar to the way we process allocations: `app.GetPlaceholderDatas()`
##########
File path: pkg/webservice/dao/application_info.go
##########
@@ -47,3 +50,11 @@ type AllocationDAOInfo struct {
ApplicationID string `json:"applicationId"`
Partition string `json:"partition"`
}
+
+type PlaceholderDAOInfo struct {
+ TaskGroupName string `json:"taskGroupName"`
+ Count int64 `json:"count"`
+ MinResource *resources.Resource `json:"minResource"`
Review comment:
This must be a string like all the other resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted commented on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064809905
@wilfred-s @yuchaoran2011 Thank you for your review.
I would like some clarifications.
Is the `replaced++` place correct?
It seems to be less than `count `at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a3b0f4) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/b0906e9f24cdaedfc0777a1340685be732afb92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0906e9) will **decrease** coverage by `0.13%`.
> The diff coverage is `77.92%`.
> :exclamation: Current head 0a3b0f4 differs from pull request most recent head b69c645. Consider uploading reports for the commit b69c645 to get more accurate results
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.52% 69.38% -0.14%
==========================================
Files 67 66 -1
Lines 9522 9516 -6
==========================================
- Hits 6620 6603 -17
- Misses 2657 2668 +11
Partials 245 245
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `74.20% <0.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <57.14%> (-1.07%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.43% <66.66%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.52% <85.71%> (+0.67%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `82.11% <100.00%> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.65% <100.00%> (-0.08%)` | :arrow_down: |
| [pkg/scheduler/placement/placement.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcGxhY2VtZW50Lmdv) | `83.33% <100.00%> (ø)` | |
| [pkg/common/resources/quantity.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZXMvcXVhbnRpdHkuZ28=) | | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0906e9...b69c645](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c81a79b) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.12%`.
> The diff coverage is `57.40%`.
> :exclamation: Current head c81a79b differs from pull request most recent head 7b55342. Consider uploading reports for the commit 7b55342 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.27% -0.13%
==========================================
Files 66 66
Lines 9475 9517 +42
==========================================
+ Hits 6576 6593 +17
- Misses 2655 2678 +23
- Partials 244 246 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.74% <55.17%> (-0.11%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <60.00%> (-0.97%)` | :arrow_down: |
| [pkg/events/event\_publisher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2V2ZW50cy9ldmVudF9wdWJsaXNoZXIuZ28=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...7b55342](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b55342) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.09%`.
> The diff coverage is `58.49%`.
> :exclamation: Current head 7b55342 differs from pull request most recent head 1dfaae7. Consider uploading reports for the commit 1dfaae7 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.30% -0.10%
==========================================
Files 66 66
Lines 9475 9516 +41
==========================================
+ Hits 6576 6595 +19
- Misses 2655 2676 +21
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.79% <57.14%> (-0.06%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <60.00%> (-0.97%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...1dfaae7](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a3b0f4) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/b0906e9f24cdaedfc0777a1340685be732afb92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0906e9) will **decrease** coverage by `0.13%`.
> The diff coverage is `77.92%`.
> :exclamation: Current head 0a3b0f4 differs from pull request most recent head 7afe973. Consider uploading reports for the commit 7afe973 to get more accurate results
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.52% 69.38% -0.14%
==========================================
Files 67 66 -1
Lines 9522 9516 -6
==========================================
- Hits 6620 6603 -17
- Misses 2657 2668 +11
Partials 245 245
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `74.20% <0.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <57.14%> (-1.07%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.43% <66.66%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.52% <85.71%> (+0.67%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `82.11% <100.00%> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.65% <100.00%> (-0.08%)` | :arrow_down: |
| [pkg/scheduler/placement/placement.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcGxhY2VtZW50Lmdv) | `83.33% <100.00%> (ø)` | |
| [pkg/common/resources/quantity.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZXMvcXVhbnRpdHkuZ28=) | | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0906e9...7afe973](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yuchaoran2011 commented on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
yuchaoran2011 commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1073045788
@wilfred-s Good point. I agree that we shouldn't consolidate multiple items in a single PR. I initially thought that those typos were introduced in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1074839774
@pbacsko could this be an issue with the changes from YUNIKORN-638:
> ```
> 2022-03-21T14:29:51.304Z ERROR cache/placeholder_manager.go:88 failed to create placeholder pod {"error": "Pod \"tg-spark-driver12324538-spark-a8949f51c61541909b1428-0\" is invalid: spec.containers[0].image: Required value"}
> github.com/apache/incubator-yunikorn-k8shim/pkg/cache.(*PlaceholderManager).createAppPlaceholders
> /home/ted/Desktop/younikon/998/incubator-yunikorn-k8shim/pkg/cache/placeholder_manager.go:88
> ```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] pbacsko edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
pbacsko edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1074984960
> @pbacsko could this be an issue with the changes from YUNIKORN-638:
>
> > ```
> > 2022-03-21T14:29:51.304Z ERROR cache/placeholder_manager.go:88 failed to create placeholder pod {"error": "Pod \"tg-spark-driver12324538-spark-a8949f51c61541909b1428-0\" is invalid: spec.containers[0].image: Required value"}
> > github.com/apache/incubator-yunikorn-k8shim/pkg/cache.(*PlaceholderManager).createAppPlaceholders
> > /home/ted/Desktop/younikon/998/incubator-yunikorn-k8shim/pkg/cache/placeholder_manager.go:88
> > ```
Yeah, but I'm not sure how. Is it coming from a running YK instance? Or an e2e test, unit test?
It's interesting because when we parse the flags, we use default values in the code, which is the usual "k8s.gcr.io/pause". Perhaps somehow an empty value was passed to the cmd line switch, like `--placeholderImage=` and `$PLACEHOLDER_IMAGE}` is undefined. That can possibly happen if YK was not deployed with helm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1075103634
Thank you for the explanation. I used this step [doc](https://yunikorn.apache.org/docs/developer_guide/deployment) to run YK. Not using helm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted commented on a change in pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on a change in pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#discussion_r831354195
##########
File path: pkg/webservice/handlers.go
##########
@@ -289,7 +292,18 @@ func getApplicationJSON(app *objects.Application) *dao.ApplicationDAOInfo {
ApplicationID: alloc.ApplicationID,
Partition: alloc.PartitionName,
}
- allocationInfos = append(allocationInfos, allocInfo)
+ allocationInfo = append(allocationInfo, allocInfo)
+ }
+
+ for _, taskGroup := range placeholders {
+ phInfo := dao.PlaceholderDAOInfo{
+ TaskGroupName: taskGroup.TaskGroupName,
Review comment:
Thanks. Add a test in handlers_test.go. Add a SetPendingAskRepeat function in allocation_ask.go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d21f4c) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.08%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 4d21f4c differs from pull request most recent head 396cb06. Consider uploading reports for the commit 396cb06 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.31% -0.09%
==========================================
Files 66 66
Lines 9475 9511 +36
==========================================
+ Hits 6576 6593 +17
- Misses 2655 2673 +18
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.33% <0.00%> (-0.10%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.49% <23.52%> (-1.33%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.18% <77.77%> (+0.32%)` | :arrow_up: |
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `97.22% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...396cb06](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d21f4c) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.08%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 4d21f4c differs from pull request most recent head ce2ee69. Consider uploading reports for the commit ce2ee69 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.31% -0.09%
==========================================
Files 66 66
Lines 9475 9511 +36
==========================================
+ Hits 6576 6593 +17
- Misses 2655 2673 +18
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.33% <0.00%> (-0.10%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.49% <23.52%> (-1.33%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.18% <77.77%> (+0.32%)` | :arrow_up: |
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `97.22% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...ce2ee69](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b55342) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.09%`.
> The diff coverage is `58.49%`.
> :exclamation: Current head 7b55342 differs from pull request most recent head e7b7a0b. Consider uploading reports for the commit e7b7a0b to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.30% -0.10%
==========================================
Files 66 66
Lines 9475 9516 +41
==========================================
+ Hits 6576 6595 +19
- Misses 2655 2676 +21
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.79% <57.14%> (-0.06%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <60.00%> (-0.97%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...e7b7a0b](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ba8dd4) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.03%`.
> The diff coverage is `77.63%`.
> :exclamation: Current head 1ba8dd4 differs from pull request most recent head 0a3b0f4. Consider uploading reports for the commit 0a3b0f4 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.36% -0.04%
==========================================
Files 66 66
Lines 9475 9516 +41
==========================================
+ Hits 6576 6601 +25
- Misses 2655 2669 +14
- Partials 244 246 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `74.20% <0.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <57.14%> (-0.97%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.43% <66.66%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.52% <85.71%> (+0.67%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `82.11% <100.00%> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.65% <100.00%> (ø)` | |
| [pkg/events/event\_publisher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2V2ZW50cy9ldmVudF9wdWJsaXNoZXIuZ28=) | `92.59% <0.00%> (-7.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...0a3b0f4](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e41ed1) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/b0906e9f24cdaedfc0777a1340685be732afb92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0906e9) will **increase** coverage by `0.10%`.
> The diff coverage is `91.11%`.
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 69.52% 69.62% +0.10%
==========================================
Files 67 67
Lines 9522 9567 +45
==========================================
+ Hits 6620 6661 +41
- Misses 2657 2661 +4
Partials 245 245
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/allocation\_ask.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb25fYXNrLmdv) | `89.61% <0.00%> (-4.92%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.88% <100.00%> (+1.03%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `76.41% <100.00%> (+0.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0906e9...4e41ed1](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] pbacsko edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
pbacsko edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1074984960
> @pbacsko could this be an issue with the changes from YUNIKORN-638:
>
> > ```
> > 2022-03-21T14:29:51.304Z ERROR cache/placeholder_manager.go:88 failed to create placeholder pod {"error": "Pod \"tg-spark-driver12324538-spark-a8949f51c61541909b1428-0\" is invalid: spec.containers[0].image: Required value"}
> > github.com/apache/incubator-yunikorn-k8shim/pkg/cache.(*PlaceholderManager).createAppPlaceholders
> > /home/ted/Desktop/younikon/998/incubator-yunikorn-k8shim/pkg/cache/placeholder_manager.go:88
> > ```
Yeah, but I'm not sure how. Is it coming from a running YK instance? Or an e2e test, unit test?
It's interesting because when we parse the flags, we use default values in the code, which is the usual "k8s.gcr.io/pause". Perhaps somehow an empty value was passed to the cmd line switch, like `--placeholderImage=` and `${PLACEHOLDER_IMAGE}` was undefined. That can possibly happen if YK was not deployed with helm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (622baa3) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.08%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 622baa3 differs from pull request most recent head c81a79b. Consider uploading reports for the commit c81a79b to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.31% -0.09%
==========================================
Files 66 66
Lines 9475 9511 +36
==========================================
+ Hits 6576 6593 +17
- Misses 2655 2673 +18
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.33% <0.00%> (-0.10%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.49% <23.52%> (-1.33%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.18% <77.77%> (+0.32%)` | :arrow_up: |
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `97.22% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...c81a79b](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e648485) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.01%`.
> The diff coverage is `77.33%`.
> :exclamation: Current head e648485 differs from pull request most recent head 1ba8dd4. Consider uploading reports for the commit 1ba8dd4 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.38% -0.02%
==========================================
Files 66 66
Lines 9475 9516 +41
==========================================
+ Hits 6576 6603 +27
- Misses 2655 2668 +13
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `74.20% <0.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <55.00%> (-0.97%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.43% <66.66%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.52% <85.71%> (+0.67%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `82.11% <100.00%> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.65% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...1ba8dd4](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] pbacsko commented on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
pbacsko commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1074984960
> @pbacsko could this be an issue with the changes from YUNIKORN-638:
>
> > ```
> > 2022-03-21T14:29:51.304Z ERROR cache/placeholder_manager.go:88 failed to create placeholder pod {"error": "Pod \"tg-spark-driver12324538-spark-a8949f51c61541909b1428-0\" is invalid: spec.containers[0].image: Required value"}
> > github.com/apache/incubator-yunikorn-k8shim/pkg/cache.(*PlaceholderManager).createAppPlaceholders
> > /home/ted/Desktop/younikon/998/incubator-yunikorn-k8shim/pkg/cache/placeholder_manager.go:88
> > ```
Yeah, but I'm not sure how. Is it coming from a running YK instance? Or an e2e test, unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted commented on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1074211144
Thanks. Added tests in these functions:
- TestAddAllocAsk
- TestReplaceAllocation
- runTimeoutPlaceholderTest
- TestTimeoutPlaceholderAllocReleased
I would like some clarifications.
I'm testing Gang Scheduling and I encountered this error, so I haven't tested successfully so far:
```
2022-03-21T14:29:51.304Z ERROR cache/placeholder_manager.go:88 failed to create placeholder pod {"error": "Pod \"tg-spark-driver12324538-spark-a8949f51c61541909b1428-0\" is invalid: spec.containers[0].image: Required value"}
github.com/apache/incubator-yunikorn-k8shim/pkg/cache.(*PlaceholderManager).createAppPlaceholders
/home/ted/Desktop/younikon/998/incubator-yunikorn-k8shim/pkg/cache/placeholder_manager.go:88
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e41ed1) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/b0906e9f24cdaedfc0777a1340685be732afb92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0906e9) will **increase** coverage by `0.10%`.
> The diff coverage is `91.11%`.
> :exclamation: Current head 4e41ed1 differs from pull request most recent head 3b12f29. Consider uploading reports for the commit 3b12f29 to get more accurate results
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 69.52% 69.62% +0.10%
==========================================
Files 67 67
Lines 9522 9567 +45
==========================================
+ Hits 6620 6661 +41
- Misses 2657 2661 +4
Partials 245 245
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/allocation\_ask.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb25fYXNrLmdv) | `89.61% <0.00%> (-4.92%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.88% <100.00%> (+1.03%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `76.41% <100.00%> (+0.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0906e9...3b12f29](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a3b0f4) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/b0906e9f24cdaedfc0777a1340685be732afb92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0906e9) will **decrease** coverage by `0.13%`.
> The diff coverage is `77.92%`.
> :exclamation: Current head 0a3b0f4 differs from pull request most recent head c96e1cc. Consider uploading reports for the commit c96e1cc to get more accurate results
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.52% 69.38% -0.14%
==========================================
Files 67 66 -1
Lines 9522 9516 -6
==========================================
- Hits 6620 6603 -17
- Misses 2657 2668 +11
Partials 245 245
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `74.20% <0.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <57.14%> (-1.07%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.43% <66.66%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.52% <85.71%> (+0.67%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `82.11% <100.00%> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `70.65% <100.00%> (-0.08%)` | :arrow_down: |
| [pkg/scheduler/placement/placement.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcGxhY2VtZW50Lmdv) | `83.33% <100.00%> (ø)` | |
| [pkg/common/resources/quantity.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZXMvcXVhbnRpdHkuZ28=) | | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0906e9...c96e1cc](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c96e1cc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/b0906e9f24cdaedfc0777a1340685be732afb92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0906e9) will **increase** coverage by `0.07%`.
> The diff coverage is `83.67%`.
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 69.52% 69.59% +0.07%
==========================================
Files 67 67
Lines 9522 9571 +49
==========================================
+ Hits 6620 6661 +41
- Misses 2657 2665 +8
Partials 245 245
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/allocation\_ask.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb25fYXNrLmdv) | `89.61% <0.00%> (-4.92%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.67% <87.09%> (+0.82%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `76.41% <100.00%> (+0.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0906e9...c96e1cc](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#discussion_r829693806
##########
File path: pkg/webservice/handlers.go
##########
@@ -289,7 +292,18 @@ func getApplicationJSON(app *objects.Application) *dao.ApplicationDAOInfo {
ApplicationID: alloc.ApplicationID,
Partition: alloc.PartitionName,
}
- allocationInfos = append(allocationInfos, allocInfo)
+ allocationInfo = append(allocationInfo, allocInfo)
+ }
+
+ for _, taskGroup := range placeholders {
+ phInfo := dao.PlaceholderDAOInfo{
+ TaskGroupName: taskGroup.TaskGroupName,
Review comment:
Need a test to cover this
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -892,6 +903,10 @@ func (sa *Application) tryPlaceholderAllocate(nodeIterator func() NodeIterator,
alloc.Result = Replaced
// mark placeholder as released
ph.released = true
+ // store number of palceHolders that have been replaced so far
+ if sa.placeholderData != nil {
+ sa.placeholderData[ph.taskGroupName].Replaced++
+ }
Review comment:
I think a better point is the real replacement: `ReplaceAllocation()`
After the check for a duplicate message. That means the placeholder is really replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] steinsgateted edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064368052
Information displayed by REST:
```
"placeholderData":[
{
"taskGroupName":"spark-driver24838",
"count":1,
"minResource":"[memory:1074 vcore:1000]",
"requiredNode":"",
"replaced":1
},
{
"taskGroupName":"spark-executor24838",
"count":4,
"minResource":"[memory:1074 vcore:1000]",
"requiredNode":"",
"replaced":0
}
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c96e1cc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/b0906e9f24cdaedfc0777a1340685be732afb92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0906e9) will **increase** coverage by `0.07%`.
> The diff coverage is `83.67%`.
> :exclamation: Current head c96e1cc differs from pull request most recent head 4e41ed1. Consider uploading reports for the commit 4e41ed1 to get more accurate results
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 69.52% 69.59% +0.07%
==========================================
Files 67 67
Lines 9522 9571 +49
==========================================
+ Hits 6620 6661 +41
- Misses 2657 2665 +8
Partials 245 245
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/allocation\_ask.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb25fYXNrLmdv) | `89.61% <0.00%> (-4.92%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.67% <87.09%> (+0.82%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `76.41% <100.00%> (+0.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0906e9...4e41ed1](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (622baa3) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.08%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.31% -0.09%
==========================================
Files 66 66
Lines 9475 9511 +36
==========================================
+ Hits 6576 6593 +17
- Misses 2655 2673 +18
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.33% <0.00%> (-0.10%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.49% <23.52%> (-1.33%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.18% <77.77%> (+0.32%)` | :arrow_up: |
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `97.22% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...622baa3](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1064362684
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b55342) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2f7ee5bd43e7cd1f5bd86118be778982b42f8d01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f7ee5b) will **decrease** coverage by `0.09%`.
> The diff coverage is `58.49%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 69.40% 69.30% -0.10%
==========================================
Files 66 66
Lines 9475 9516 +41
==========================================
+ Hits 6576 6595 +19
- Misses 2655 2676 +21
- Partials 244 245 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.79% <57.14%> (-0.06%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `74.85% <60.00%> (-0.97%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f7ee5b...7b55342](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org