You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Abraham Fine (JIRA)" <ji...@apache.org> on 2015/10/10 01:51:05 UTC

[jira] [Commented] (SQOOP-2497) Sqoop2: Do not require constructors initializing all properties in configuration objects

    [ https://issues.apache.org/jira/browse/SQOOP-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951414#comment-14951414 ] 

Abraham Fine commented on SQOOP-2497:
-------------------------------------

the code still needs some cleanup, but it should be functional.

> Sqoop2: Do not require constructors initializing all properties in configuration objects
> ----------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2497
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2497
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.6
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Abraham Fine
>             Fix For: 1.99.7
>
>
> On internal hackathon we we're hacking Sqoop 2 connector with [~singhashish] and we went through few troubles that we should address.
> We currently require that all properties are properly initialized in object creation - for example check the [LinkConfiguration|https://github.com/apache/sqoop/blob/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java] constructor from Generic JDBC connector. Otherwise we get "funny" {{NullPointerExceptions}}  in [ConfigUtils|https://github.com/apache/sqoop/blob/sqoop2/common/src/main/java/org/apache/sqoop/model/ConfigUtils.java]. I think that we should simply make {{ConfigUtils}} smart enough to deal with the {{null}} and not force all developers to put unnecessary lines of code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)