You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/21 02:08:53 UTC

[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #5548: [Issue #4330]Support broker priority election for controller mode

tsunghanjacktsai commented on code in PR #5548:
URL: https://github.com/apache/rocketmq/pull/5548#discussion_r1027447002


##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -336,6 +336,10 @@ public class BrokerConfig extends BrokerIdentity {
 
     private long syncControllerMetadataPeriod = 10 * 1000;
 
+    // It is an important basis for the controller to choose the broker master. Under the same conditions,

Review Comment:
   How about making the definition of "higher priority" clearer in the comment or the document? Like is the priority higher while the value of brokerElectionPriority is larger or smaller?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org