You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ScrapCodes <gi...@git.apache.org> on 2017/05/15 07:09:54 UTC
[GitHub] spark pull request #17983: [SPARK-20738][BUILD] Hide building of docs in sbt...
GitHub user ScrapCodes opened a pull request:
https://github.com/apache/spark/pull/17983
[SPARK-20738][BUILD] Hide building of docs in sbt behind an option.
sbt publish-local tries to build the docs along with other artifacts
and as the codebase is being updated with no build checks for sbt docs build.
It appears to be difficult to upkeep the correct building of docs with sbt.
An alternative is that, we hide building of docs behind an option `-Dbuild.docs=false`.
This is also useful, if someone uses sbt publish and does not need the building of docs
as it is generally time consuming.
## How was this patch tested?
Manually running the build with and without the option.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ScrapCodes/spark build-docs-sbt
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17983.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17983
----
commit a43159e6b58dba70e11b5f2f52abbc2ab4a577dc
Author: Prashant Sharma <pr...@in.ibm.com>
Date: 2017-05-15T06:53:58Z
[BUILD][MINOR] Hide building of docs in sbt behind an option.
sbt publish-local tries to build the docs along with other artifacts
and as the codebase is being updated with no build checks for sbt docs build.
It appears to be difficult to upkeep the correct building of docs with sbt.
An alternative is that, we hide building of docs behind an option `-Dbuild.docs=false`.
This is also useful, if someone uses sbt publish and does not need the building of docs
as it is generally time consuming.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17983: [SPARK-20738][BUILD] Hide building of docs in sbt behind...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17983
**[Test build #76934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76934/testReport)** for PR 17983 at commit [`a43159e`](https://github.com/apache/spark/commit/a43159e6b58dba70e11b5f2f52abbc2ab4a577dc).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17983: [SPARK-20738][BUILD] Hide building of docs in sbt behind...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17983
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76934/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17983: [SPARK-20738][BUILD] Option to turn off building ...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes closed the pull request at:
https://github.com/apache/spark/pull/17983
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17983: [SPARK-20738][BUILD] Hide building of docs in sbt behind...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17983
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17983: [SPARK-20738][BUILD] Hide building of docs in sbt behind...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17983
**[Test build #76934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76934/testReport)** for PR 17983 at commit [`a43159e`](https://github.com/apache/spark/commit/a43159e6b58dba70e11b5f2f52abbc2ab4a577dc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17983: [SPARK-20738][BUILD] Option to turn off building docs in...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17983
@srowen Can you please take a look !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org