You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/02 11:37:20 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #9451:
release: Add support for ZSH in RELEASING and add tagging instructions
villebro opened a new pull request #9451: release: Add support for ZSH in RELEASING and add tagging instructions
URL: https://github.com/apache/incubator-superset/pull/9451
### CATEGORY
Choose one
- [x] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [x] Build / Development Environment
- [x] Documentation
### SUMMARY
Currently the release script don't support ZSH properly, causing trouble when crafting a release on MacOS Catalina. Also added instructions for tagging and pushing the tag.
### REVIEWERS
@dpgaspar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #9451: release:
Add support for ZSH in RELEASING and add tagging instructions
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #9451: release: Add support for ZSH in RELEASING and add tagging instructions
URL: https://github.com/apache/incubator-superset/pull/9451
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9451: release:
Add support for ZSH in RELEASING and add tagging instructions
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9451: release: Add support for ZSH in RELEASING and add tagging instructions
URL: https://github.com/apache/incubator-superset/pull/9451#issuecomment-607801448
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=h1) Report
> Merging [#9451](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e33f6c244d9cb54361166ef8609cd121b08e163e&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9451 +/- ##
=======================================
Coverage 59.02% 59.02%
=======================================
Files 379 379
Lines 12189 12189
Branches 3014 3014
=======================================
Hits 7194 7194
Misses 4814 4814
Partials 181 181
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=footer). Last update [e33f6c2...6913d57](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9451:
release: Add support for ZSH in RELEASING and add tagging instructions
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9451: release: Add support for ZSH in RELEASING and add tagging instructions
URL: https://github.com/apache/incubator-superset/pull/9451#issuecomment-607801448
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=h1) Report
> Merging [#9451](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e33f6c244d9cb54361166ef8609cd121b08e163e&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9451 +/- ##
==========================================
- Coverage 59.02% 59.01% -0.01%
==========================================
Files 379 382 +3
Lines 12189 12191 +2
Branches 3014 3014
==========================================
Hits 7194 7194
- Misses 4814 4815 +1
- Partials 181 182 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/explore/controlPanels/sections.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9451/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9zZWN0aW9ucy5qc3g=) | `100.00% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/DeckScatter.js](https://codecov.io/gh/apache/incubator-superset/pull/9451/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrU2NhdHRlci5qcw==) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9451/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrTXVsdGkuanM=) | `0.00% <0.00%> (ø)` | |
| [...tend/src/explore/controlPanels/Shared\_BigNumber.js](https://codecov.io/gh/apache/incubator-superset/pull/9451/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfQmlnTnVtYmVyLmpz) | `0.00% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/DeckGeojson.js](https://codecov.io/gh/apache/incubator-superset/pull/9451/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrR2VvanNvbi5qcw==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9451/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `40.31% <0.00%> (+1.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=footer). Last update [e33f6c2...5f33bc3](https://codecov.io/gh/apache/incubator-superset/pull/9451?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org