You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2002/07/15 09:45:11 UTC
cvs commit: httpd-2.0/modules/metadata mod_unique_id.c
wrowe 2002/07/15 00:45:11
Modified: modules/metadata mod_unique_id.c
Log:
The macros remove how much legibility?
Revision Changes Path
1.41 +1 -3 httpd-2.0/modules/metadata/mod_unique_id.c
Index: mod_unique_id.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/metadata/mod_unique_id.c,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- mod_unique_id.c 30 Jun 2002 04:30:41 -0000 1.40
+++ mod_unique_id.c 15 Jul 2002 07:45:11 -0000 1.41
@@ -175,7 +175,6 @@
static int unique_id_global_init(apr_pool_t *p, apr_pool_t *plog, apr_pool_t *ptemp, server_rec *main_server)
{
char str[APRMAXHOSTLEN + 1];
- apr_short_interval_time_t pause;
apr_status_t rv;
char *ipaddrstr;
apr_sockaddr_t *sockaddr;
@@ -253,8 +252,7 @@
* next second.
*/
now = apr_time_now();
- pause = (apr_short_interval_time_t)(1000000 - apr_time_usec(now));
- apr_sleep(pause);
+ apr_sleep(apr_time_from_sec(1));
return OK;
}
RE: cvs commit: httpd-2.0/modules/metadata mod_unique_id.c
Posted by Sander Striker <st...@apache.org>.
> From: Brian Pane [mailto:bpane@pacbell.net]
> Sent: 15 July 2002 10:10
> On Mon, 2002-07-15 at 01:13, Sander Striker wrote:
> > Doesn't this change make us sleep a full second now, instead of the
> > remainder of the current second?
> >
> > Sander
> >
>
> Yes, but it only happens once, during startup, so it doesn't
> matter much.
>
> --Brian
In that case, the comment above the sleep call should be tweaked.
Because it doesn't do what it says now.
... sees wrowes commit...
Nevermind.
Sander
RE: cvs commit: httpd-2.0/modules/metadata mod_unique_id.c
Posted by Brian Pane <bp...@pacbell.net>.
On Mon, 2002-07-15 at 01:13, Sander Striker wrote:
> Doesn't this change make us sleep a full second now, instead of the
> remainder of the current second?
>
> Sander
>
Yes, but it only happens once, during startup, so it doesn't
matter much.
--Brian
> > From: wrowe@apache.org [mailto:wrowe@apache.org]
> > Sent: 15 July 2002 09:45
> > To: httpd-2.0-cvs@apache.org
> > Subject: cvs commit: httpd-2.0/modules/metadata mod_unique_id.c
> >
> >
> > wrowe 2002/07/15 00:45:11
> >
> > Modified: modules/metadata mod_unique_id.c
> > Log:
> > The macros remove how much legibility?
> >
> > Revision Changes Path
> > 1.41 +1 -3 httpd-2.0/modules/metadata/mod_unique_id.c
> >
> > Index: mod_unique_id.c
> > ===================================================================
> > RCS file: /home/cvs/httpd-2.0/modules/metadata/mod_unique_id.c,v
> > retrieving revision 1.40
> > retrieving revision 1.41
> > diff -u -r1.40 -r1.41
> > --- mod_unique_id.c 30 Jun 2002 04:30:41 -0000 1.40
> > +++ mod_unique_id.c 15 Jul 2002 07:45:11 -0000 1.41
> > @@ -175,7 +175,6 @@
> > static int unique_id_global_init(apr_pool_t *p, apr_pool_t *plog, apr_pool_t *ptemp, server_rec *main_server)
> > {
> > char str[APRMAXHOSTLEN + 1];
> > - apr_short_interval_time_t pause;
> > apr_status_t rv;
> > char *ipaddrstr;
> > apr_sockaddr_t *sockaddr;
> > @@ -253,8 +252,7 @@
> > * next second.
> > */
> > now = apr_time_now();
> > - pause = (apr_short_interval_time_t)(1000000 - apr_time_usec(now));
> > - apr_sleep(pause);
> > + apr_sleep(apr_time_from_sec(1));
> > return OK;
> > }
>
RE: cvs commit: httpd-2.0/modules/metadata mod_unique_id.c
Posted by Sander Striker <st...@apache.org>.
Doesn't this change make us sleep a full second now, instead of the
remainder of the current second?
Sander
> From: wrowe@apache.org [mailto:wrowe@apache.org]
> Sent: 15 July 2002 09:45
> To: httpd-2.0-cvs@apache.org
> Subject: cvs commit: httpd-2.0/modules/metadata mod_unique_id.c
>
>
> wrowe 2002/07/15 00:45:11
>
> Modified: modules/metadata mod_unique_id.c
> Log:
> The macros remove how much legibility?
>
> Revision Changes Path
> 1.41 +1 -3 httpd-2.0/modules/metadata/mod_unique_id.c
>
> Index: mod_unique_id.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/modules/metadata/mod_unique_id.c,v
> retrieving revision 1.40
> retrieving revision 1.41
> diff -u -r1.40 -r1.41
> --- mod_unique_id.c 30 Jun 2002 04:30:41 -0000 1.40
> +++ mod_unique_id.c 15 Jul 2002 07:45:11 -0000 1.41
> @@ -175,7 +175,6 @@
> static int unique_id_global_init(apr_pool_t *p, apr_pool_t *plog, apr_pool_t *ptemp, server_rec *main_server)
> {
> char str[APRMAXHOSTLEN + 1];
> - apr_short_interval_time_t pause;
> apr_status_t rv;
> char *ipaddrstr;
> apr_sockaddr_t *sockaddr;
> @@ -253,8 +252,7 @@
> * next second.
> */
> now = apr_time_now();
> - pause = (apr_short_interval_time_t)(1000000 - apr_time_usec(now));
> - apr_sleep(pause);
> + apr_sleep(apr_time_from_sec(1));
> return OK;
> }