You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Peter Courcoux <pe...@courcoux.biz> on 2003/11/08 23:30:30 UTC

[validator] EmailTest failing

Hi all,

I did a fresh checkout of validator this evening and the EmailTest
failed. I'll look into this myself when I have a moment. However, I
thought I'd ask if this is a known issue? I didn't see anything in the
archives.

Report follows:-

Testsuite: org.apache.commons.validator.EmailTest
Tests run: 7, Failures: 1, Errors: 0, Time elapsed: 4.45 sec

Testcase: testEmail took 2.97 sec
Testcase: testEmailExtension took 0.475 sec
Testcase: testEmailWithDash took 0.208 sec
Testcase: testEmailWithDotEnd took 0.194 sec
Testcase: testEmailWithBogusCharacter took 0.18 sec
Testcase: testEmailWithCommas took 0.191 sec
Testcase: testEmailUserName took 0.194 sec
	FAILED
Value joe+@apache.orgValidatorResult for the 'email' action should have failed.
junit.framework.AssertionFailedError: Value joe+@apache.orgValidatorResult for the 'email' action should have failed.
	at org.apache.commons.validator.EmailTest.valueTest(EmailTest.java:341)
	at org.apache.commons.validator.EmailTest.testEmailUserName(EmailTest.java:256)
	at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:232)
	at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279)
	at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135)
	at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233)
	at org.apache.commons.jelly.tags.core.IfTag.doTag(IfTag.java:88)
	at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279)
	at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135)
	at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233)
	at com.werken.werkz.jelly.GoalTag$1.performAction(GoalTag.java:128)
	at com.werken.werkz.Goal.fire(Goal.java:639)
	at com.werken.werkz.Goal.attain(Goal.java:575)
	at com.werken.werkz.Goal.attainPrecursors(Goal.java:488)
	at com.werken.werkz.Goal.attain(Goal.java:573)
	at com.werken.werkz.Goal.attainPrecursors(Goal.java:488)
	at com.werken.werkz.Goal.attain(Goal.java:573)
	at org.apache.maven.plugin.PluginManager.attainGoals(PluginManager.java:454)
	at org.apache.maven.MavenSession.attainGoals(MavenSession.java:348)
	at org.apache.maven.cli.App.doMain(App.java:543)
	at org.apache.maven.cli.App.main(App.java:1109)
	at com.werken.forehead.Forehead.run(Forehead.java:543)
	at com.werken.forehead.Forehead.main(Forehead.java:573)

Testcase: testEmailUserName 

Regards,
-- 
Peter Courcoux <pe...@courcoux.biz>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org

Re: [validator] EmailTest failing

Posted by Peter Courcoux <pe...@courcoux.biz>.
Rob,

Thanks for the reply.

I'll have to look up RFC822...

Regards,

Peter

On Mon, 2003-11-10 at 04:27, Robert Leland wrote:
> Peter Courcoux wrote:
> 
> >Hi all,
> >
> >I did a fresh checkout of validator this evening and the EmailTest
> >failed. 
> >
> Your correct, those tests were added as a reminder to review the 
> RFC822.txt and handle cases of specialized
> characters in the users name. Most of the time the character string 
> needs to be commented. Unfortunately, I have not
> had time lately to go back and added this to the regular expressions.
> 
> >I'll look into this myself when I have a moment. However, I
> >  
> >
> Patches or code review is always welcome !
> 
> >thought I'd ask if this is a known issue? I didn't see anything in the
> >archives.
> >
> >Regards,
> >  
> >
> -Rob
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
-- 
Peter Courcoux <pe...@courcoux.biz>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org

Re: [validator] EmailTest failing

Posted by Robert Leland <rl...@apache.org>.
Peter Courcoux wrote:

>Hi all,
>
>I did a fresh checkout of validator this evening and the EmailTest
>failed. 
>
Your correct, those tests were added as a reminder to review the 
RFC822.txt and handle cases of specialized
characters in the users name. Most of the time the character string 
needs to be commented. Unfortunately, I have not
had time lately to go back and added this to the regular expressions.

>I'll look into this myself when I have a moment. However, I
>  
>
Patches or code review is always welcome !

>thought I'd ask if this is a known issue? I didn't see anything in the
>archives.
>
>Regards,
>  
>
-Rob


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org