You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by guoxiaolongzte <gi...@git.apache.org> on 2017/04/05 03:50:25 UTC
[GitHub] spark pull request #17534: [SPARK-20218]'/applications/[app-id]/stages' in R...
GitHub user guoxiaolongzte opened a pull request:
https://github.com/apache/spark/pull/17534
[SPARK-20218]'/applications/[app-id]/stages' in REST API,add description.
## What changes were proposed in this pull request?
'/applications/[app-id]/stages' in rest api.status should add description '?status=[active|complete|pending|failed] list only stages in the state.'
Now the lack of this description, resulting in the use of this api do not know the use of the status through the brush stage list.
code:
@GET
def stageList(@QueryParam("status") statuses: JList[StageStatus]): Seq[StageData] = {
val listener = ui.jobProgressListener
val stageAndStatus = AllStagesResource.stagesAndStatus(ui)
val adjStatuses = {
if (statuses.isEmpty())
{ Arrays.asList(StageStatus.values(): _*) }
else
{ statuses }
};
## How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoxiaolongzte/spark SPARK-20218
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17534
----
commit d383efba12c66addb17006dea107bb0421d50bc3
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date: 2017-03-31T13:57:09Z
[SPARK-20177]Document about compression way has some little detail changes.
commit 3059013e9d2aec76def14eb314b6761bea0e7ca0
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date: 2017-04-01T01:38:02Z
[SPARK-20177] event log add a space
commit 46bb1ad3ddd9fb55b5607ac4f20213a90186cfe9
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date: 2017-04-05T03:16:50Z
Merge branch 'master' of https://github.com/apache/spark into SPARK-20177
commit 0efb0dd9e404229cce638fe3fb0c966276784df7
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date: 2017-04-05T03:47:53Z
[SPARK-20218]'/applications/[app-id]/stages' in REST API,add description.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17534: [SPARK-20218]'/applications/[app-id]/stages' in REST API...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17534
Why didn't you add this to your last PR? What other related changes do you want to make? Making several small closely related PRs is frowned on
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17534: [SPARK-20218]'/applications/[app-id]/stages' in REST API...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17534
**[Test build #3644 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3644/testReport)** for PR 17534 at commit [`0e37fde`](https://github.com/apache/spark/commit/0e37fdeee28e31fc97436dabd001d3c85c5a7794).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17534: [SPARK-20218]'/applications/[app-id]/stages' in R...
Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on a diff in the pull request:
https://github.com/apache/spark/pull/17534#discussion_r110303522
--- Diff: docs/monitoring.md ---
@@ -299,12 +299,12 @@ can be identified by their `[attempt-id]`. In the API listed below, when running
<tr>
<td><code>/applications/[app-id]/stages</code></td>
<td>A list of all stages for a given application.</td>
+ <br><code>?status=[active|complete|pending|failed]</code> list only stages in the state.
</tr>
<tr>
<td><code>/applications/[app-id]/stages/[stage-id]</code></td>
<td>
A list of all attempts for the given stage.
- <br><code>?status=[active|complete|pending|failed]</code> list only stages in the state.
--- End diff --
It is filtering stages.
I have manual test this API locally and confirm this doesn't have effect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17534: [SPARK-20218]'/applications/[app-id]/stages' in REST API...
Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/17534
Added one more
2.'/applications/[app-id]/stages/[stage-id]' in REST API,remove redundant description \u2018?status=[active|complete|pending|failed] list only stages in the state.\u2019.
Because only one stage is determined based on stage-id.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17534: [SPARK-20218]'/applications/[app-id]/stages' in R...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17534#discussion_r110198657
--- Diff: docs/monitoring.md ---
@@ -299,12 +299,12 @@ can be identified by their `[attempt-id]`. In the API listed below, when running
<tr>
<td><code>/applications/[app-id]/stages</code></td>
<td>A list of all stages for a given application.</td>
+ <br><code>?status=[active|complete|pending|failed]</code> list only stages in the state.
</tr>
<tr>
<td><code>/applications/[app-id]/stages/[stage-id]</code></td>
<td>
A list of all attempts for the given stage.
- <br><code>?status=[active|complete|pending|failed]</code> list only stages in the state.
--- End diff --
Is it filtering stages? or attempts? I am not familiar with this but it wasn't obvious that this is redundant. Maybe you have tried this API locally and confirm this doesn't have effect?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17534: [SPARK-20218]'/applications/[app-id]/stages' in REST API...
Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/17534
Because I just use this API today to develop, only to find the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17534: [SPARK-20218][Doc]'/applications/[app-id]/stages' in RES...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17534
Merged to master/2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17534: [SPARK-20218]'/applications/[app-id]/stages' in REST API...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17534
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17534: [SPARK-20218][Doc]'/applications/[app-id]/stages'...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17534: [SPARK-20218]'/applications/[app-id]/stages' in REST API...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17534
**[Test build #3644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3644/testReport)** for PR 17534 at commit [`0e37fde`](https://github.com/apache/spark/commit/0e37fdeee28e31fc97436dabd001d3c85c5a7794).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org