[GitHub] [incubator-doris] marising commented on a change in pull request #3577: [Fix]SlotRef.tosql() is the same as the SQL returned by different sql

[GitBox <gi...@apache.org>]

marising commented on a change in pull request #3577:
URL: https://github.com/apache/incubator-doris/pull/3577#discussion_r425241822



##########
File path: fe/src/main/java/org/apache/doris/analysis/SlotRef.java
##########
@@ -162,6 +162,12 @@ public String toSqlImpl() {
             return tblName.toSql() + "." + label + sb.toString();
         } else if (label != null) {
             return label + sb.toString();
+        } else if (desc.getSourceExprs() != null) {
+            for (Expr expr : desc.getSourceExprs()) {
+                sb.append(expr.toSql());
+                sb.append(" ");
+            }
+            return sb.toString();

Review comment:
       How about slot ID and expr? I need MD5 of SQL as the key of cache instead of slot ID. I'm trying to fix the other unit tests
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org