You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "unikdahal (via GitHub)" <gi...@apache.org> on 2026/07/03 20:45:35 UTC

[PR] Fixed double closing of client [arrow-adbc]

unikdahal opened a new pull request, #4465:
URL: https://github.com/apache/arrow-adbc/pull/4465

   Closes #4464


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(java/driver/flight-sql) Fixed double closing of client [arrow-adbc]

Posted by "unikdahal (via GitHub)" <gi...@apache.org>.
unikdahal commented on PR #4465:
URL: https://github.com/apache/arrow-adbc/pull/4465#issuecomment-4881274045

   @amoeba @zeroshade @lidavidm can you guys review it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(java/driver/flight-sql): avoid double-closing client [arrow-adbc]

Posted by "unikdahal (via GitHub)" <gi...@apache.org>.
unikdahal commented on PR #4465:
URL: https://github.com/apache/arrow-adbc/pull/4465#issuecomment-4929135046

   > The test doesn't fail even if I revert the change in FlightSqlConnection.
   
   The tests I added were just basic checks that resources get freed and are not specifically testing the double-close fix itself.
   
   For a test that actually covers the fix: is it okay if I use reflection here to swap in a fake client that counts close() calls, or would you rather I add a seam for it instead? @lidavidm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(java/driver/flight-sql): avoid double-closing client [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #4465:
URL: https://github.com/apache/arrow-adbc/pull/4465#issuecomment-4930071092

   I guess I don't see the problem in the first place if the double close doesn't actually do anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(java/driver/flight-sql) Fixed double closing of client [arrow-adbc]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #4465:
URL: https://github.com/apache/arrow-adbc/pull/4465#issuecomment-4883212131

   This LGTM but can you add a test for it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(java/driver/flight-sql): avoid double-closing client [arrow-adbc]

Posted by "unikdahal (via GitHub)" <gi...@apache.org>.
unikdahal commented on PR #4465:
URL: https://github.com/apache/arrow-adbc/pull/4465#issuecomment-4932019480

   Fair enough, closing it then, though it's still relying on Arrow's idempotency as an implementation detail rather than something we guarantee ourselves, so worth keeping in mind if that ever changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(java/driver/flight-sql): avoid double-closing client [arrow-adbc]

Posted by "unikdahal (via GitHub)" <gi...@apache.org>.
unikdahal closed pull request #4465: fix(java/driver/flight-sql): avoid double-closing client
URL: https://github.com/apache/arrow-adbc/pull/4465


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org