[GitHub] [knox] smolnar82 commented on a change in pull request #249: KNOX-2213 - Service Discovery Support for CM UI, API

[GitBox <gi...@apache.org>]

smolnar82 commented on a change in pull request #249: KNOX-2213 - Service Discovery Support for CM UI, API
URL: https://github.com/apache/knox/pull/249#discussion_r373570304
 
 

 ##########
 File path: gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerServiceDiscovery.java
 ##########
 @@ -202,6 +204,22 @@ private static Cluster discoverCluster(DiscoveryApiClient client, String cluster
           }
         }
       }
+      /* Since Cloudera Manager does not have a service for itself, we will add a skeleton CM
+      service so that we can add CM service to topology when auto-discovery is
+      turned on and CM service is selected in the descriptor */
+      List<ServiceModelGenerator> smgList = serviceModelGenerators
+          .get(CM_SERVICE_TYPE);
+      if (smgList != null) {
+        for (ServiceModelGenerator serviceModelGenerator : smgList) {
+          if (serviceModelGenerator != null) {
+            serviceModelGenerator.setApiClient(client);
+            ServiceModel serviceModel = serviceModelGenerator
+                .generateService(null, null, null, null);
+            serviceModels.add(serviceModel);
+          }
+        }
+      }
+
 
 Review comment:
   I believe it would be easier to read and understand later on if you add the CM service above to `serviceList` and modify `getRoles(rolesResourceApi, clusterName, serviceName)` to fetch the roles using the CM REST API for other services and add CM API/UI role manually. Then you would not have to copy-paste the logic which checks service model generators

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services