You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/07/16 19:22:45 UTC

[GitHub] mitchell852 commented on a change in pull request #2547: TO DB: update boolean fields and add NOT NULL constraints

mitchell852 commented on a change in pull request #2547: TO DB: update boolean fields and add NOT NULL constraints
URL: https://github.com/apache/trafficcontrol/pull/2547#discussion_r202794995
 
 

 ##########
 File path: traffic_ops/app/db/patches.sql
 ##########
 @@ -39,3 +39,25 @@ ALTER TABLE deliveryservice ADD CONSTRAINT routing_name_not_empty CHECK (length(
 -- altering any enum values within a transaction block and by default
 -- goose runs migrations within a transaction.
 ALTER TYPE profile_type ADD VALUE IF NOT EXISTS 'GROVE_PROFILE';
+
+-- not enough to make boolean default false -- enforce that API can't set it to NULL
+UPDATE cachegroup
 
 Review comment:
   all these columns are of type boolean and default=false?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services