You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hongtu Zang <ho...@tcloudcomputing.com> on 2013/03/12 16:51:45 UTC

Review Request: fix CLOUDSTACK-1649

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9879/
-----------------------------------------------------------

Review request for cloudstack, Nitin Mehta, edison su, and mice xia.


Description
-------

a mapping bug.
in db the os name is "Red Hat Enterprise Linux 5.1 (64-bit)", but in the VmwareGuestOSMapper is "Red Hat Enterprise Linux 5.1(64-bit)"


This addresses bug CLOUDSTACK-1649.


Diffs
-----

  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java 7d26983 

Diff: https://reviews.apache.org/r/9879/diff/


Testing
-------

Upload a redhat 5.1 iso
start a vm with it.
check the os type in vsphere client, the os type is red hat not the other 64.


Thanks,

Hongtu Zang


Re: Review Request: fix CLOUDSTACK-1649

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9879/#review17908
-----------------------------------------------------------


Applied to 4.1 (and I'll apply to master shortly).  Thanks for the patch!

- Chip Childers


On March 13, 2013, 6:11 a.m., Hongtu Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9879/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 6:11 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, mice xia, and Kelven Yang.
> 
> 
> Description
> -------
> 
> a mapping bug.
> in db the os name is "Red Hat Enterprise Linux 5.1 (64-bit)", but in the VmwareGuestOSMapper is "Red Hat Enterprise Linux 5.1(64-bit)"
> 
> 
> This addresses bug CLOUDSTACK-1649.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java 7d26983 
> 
> Diff: https://reviews.apache.org/r/9879/diff/
> 
> 
> Testing
> -------
> 
> Upload a redhat 5.1 iso
> start a vm with it.
> check the os type in vsphere client, the os type is red hat not the other 64.
> 
> 
> Thanks,
> 
> Hongtu Zang
> 
>


Re: Review Request: fix CLOUDSTACK-1649

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9879/#review17909
-----------------------------------------------------------

Ship it!


Ship It!

- Chip Childers


On March 13, 2013, 6:11 a.m., Hongtu Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9879/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 6:11 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, mice xia, and Kelven Yang.
> 
> 
> Description
> -------
> 
> a mapping bug.
> in db the os name is "Red Hat Enterprise Linux 5.1 (64-bit)", but in the VmwareGuestOSMapper is "Red Hat Enterprise Linux 5.1(64-bit)"
> 
> 
> This addresses bug CLOUDSTACK-1649.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java 7d26983 
> 
> Diff: https://reviews.apache.org/r/9879/diff/
> 
> 
> Testing
> -------
> 
> Upload a redhat 5.1 iso
> start a vm with it.
> check the os type in vsphere client, the os type is red hat not the other 64.
> 
> 
> Thanks,
> 
> Hongtu Zang
> 
>


Re: Review Request: fix CLOUDSTACK-1649

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9879/#review17910
-----------------------------------------------------------


Commit 0bf5f5edec0b9f74f677352b43c25cfcc560fb31 in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=0bf5f5e ]

CLOUDSTACK-1649: VMware VM OS type errors for RHEL
Signed-off-by: Chip Childers <ch...@gmail.com>


- ASF Subversion and Git Services


On March 13, 2013, 6:11 a.m., Hongtu Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9879/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 6:11 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, mice xia, and Kelven Yang.
> 
> 
> Description
> -------
> 
> a mapping bug.
> in db the os name is "Red Hat Enterprise Linux 5.1 (64-bit)", but in the VmwareGuestOSMapper is "Red Hat Enterprise Linux 5.1(64-bit)"
> 
> 
> This addresses bug CLOUDSTACK-1649.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java 7d26983 
> 
> Diff: https://reviews.apache.org/r/9879/diff/
> 
> 
> Testing
> -------
> 
> Upload a redhat 5.1 iso
> start a vm with it.
> check the os type in vsphere client, the os type is red hat not the other 64.
> 
> 
> Thanks,
> 
> Hongtu Zang
> 
>


Re: Review Request: fix CLOUDSTACK-1649

Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9879/
-----------------------------------------------------------

(Updated March 13, 2013, 6:11 a.m.)


Review request for cloudstack, Abhinandan Prateek, mice xia, and Kelven Yang.


Changes
-------

correcting the reviewers for looking into the guestOS mappings


Description
-------

a mapping bug.
in db the os name is "Red Hat Enterprise Linux 5.1 (64-bit)", but in the VmwareGuestOSMapper is "Red Hat Enterprise Linux 5.1(64-bit)"


This addresses bug CLOUDSTACK-1649.


Diffs
-----

  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java 7d26983 

Diff: https://reviews.apache.org/r/9879/diff/


Testing
-------

Upload a redhat 5.1 iso
start a vm with it.
check the os type in vsphere client, the os type is red hat not the other 64.


Thanks,

Hongtu Zang