You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "link3280 (via GitHub)" <gi...@apache.org> on 2024/07/23 06:30:31 UTC
[PR] [AMORO-3056] Support graceful shutdown for AMS [amoro]
link3280 opened a new pull request, #3057:
URL: https://github.com/apache/amoro/pull/3057
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #3056.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
-
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3056] Support graceful shutdown for AMS [amoro]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3057:
URL: https://github.com/apache/amoro/pull/3057#issuecomment-2245643460
## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3057?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `5.55556%` with `17 lines` in your changes missing coverage. Please review.
> Project coverage is 32.79%. Comparing base [(`49cacc1`)](https://app.codecov.io/gh/apache/amoro/commit/49cacc1d287dc6917d20362e74f391235c710f99?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5a03dd0`)](https://app.codecov.io/gh/apache/amoro/commit/5a03dd0984d60663565417e9c4e88f0ad7b07585?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 3 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/amoro/pull/3057?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...org/apache/amoro/server/AmoroServiceContainer.java](https://app.codecov.io/gh/apache/amoro/pull/3057?src=pr&el=tree&filepath=amoro-ams%2Famoro-ams-server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fserver%2FAmoroServiceContainer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tYW1zL2Ftb3JvLWFtcy1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Ftb3JvL3NlcnZlci9BbW9yb1NlcnZpY2VDb250YWluZXIuamF2YQ==) | 0.00% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/amoro/server/terminal/TerminalManager.java](https://app.codecov.io/gh/apache/amoro/pull/3057?src=pr&el=tree&filepath=amoro-ams%2Famoro-ams-server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fserver%2Fterminal%2FTerminalManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tYW1zL2Ftb3JvLWFtcy1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Ftb3JvL3NlcnZlci90ZXJtaW5hbC9UZXJtaW5hbE1hbmFnZXIuamF2YQ==) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3057 +/- ##
============================================
+ Coverage 32.77% 32.79% +0.02%
- Complexity 3827 3837 +10
============================================
Files 558 558
Lines 46249 46276 +27
Branches 6120 6119 -1
============================================
+ Hits 15157 15177 +20
- Misses 29895 29903 +8
+ Partials 1197 1196 -1
```
| [Flag](https://app.codecov.io/gh/apache/amoro/pull/3057/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core](https://app.codecov.io/gh/apache/amoro/pull/3057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <5.55%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/3057?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3056] Support graceful shutdown for AMS [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #3057:
URL: https://github.com/apache/amoro/pull/3057#issuecomment-2247037144
Thanks for the contribution! @link3280
Thanks for the review! @XBaith
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3056] Support graceful shutdown for AMS [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3057:
URL: https://github.com/apache/amoro/pull/3057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org