You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by jaltekruse <gi...@git.apache.org> on 2016/02/27 00:57:44 UTC

[GitHub] drill pull request: DRILL-4437: Operator unit tests

GitHub user jaltekruse opened a pull request:

    https://github.com/apache/drill/pull/394

    DRILL-4437: Operator unit tests

    Introduces a framework for testing physical operators without the need to start a complete Drill server.
    
    Several small interface changes were made to allow for the test declarations to be cleaner or to share code with some existing test infrastructure. I went ahead and opened JIRAs for them, but they are included on this branch as individual commits. If any of these changes are too large I can break them out into separate reviews.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaltekruse/incubator-drill 4437-op-unit-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #394
    
----
commit 571c90cfda04310b3ff659a42c13f52b714848e5
Author: Jason Altekruse <al...@gmail.com>
Date:   2016-02-11T01:36:47Z

    DRILL-4445: Standardize the Physical and Logical plan nodes to use Lists instead of arrays for their inputs
    
    Remove some extra translation logic used to move between the
    two representations.
    
    TODO - look back the the Join logical node, has two JsonCreator annotations,
    but only one will be used. Not sure if the behavior of which is chosen
    is considered documented behavior, should just fix it on our end.

commit e034dc5276af51241afba839cdf5da2c4930caf7
Author: Jason Altekruse <al...@gmail.com>
Date:   2016-02-25T03:37:21Z

    DRILL-4448: Clean up deserialization of oderings in sorts

commit 9c2b061610be052b1b05d2e86228b6914a395cc8
Author: Jason Altekruse <al...@gmail.com>
Date:   2016-02-26T22:11:47Z

    DRILL-4442: Move getSV2 and getSV4 methods to VectorAccessible
    
    Up one level from previous location RecordBatch, most implementations
    already implement the method as they implement RecordBatch rather than
    VectorAccessible itself. Add unsupported operation exception to others.

commit 28280456f4f0766d6b2e1c78dff5334cde56afe3
Author: Jason Altekruse <al...@gmail.com>
Date:   2016-02-26T22:55:30Z

    DRILL-4437: Operator unit test framework

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4437: Operator unit tests

Posted by jaltekruse <gi...@git.apache.org>.

Github user jaltekruse commented on the pull request:

    https://github.com/apache/drill/pull/394#issuecomment-190353355
  
    @sudheeshkatkam @parthchandra @adeneche @StevenMPhillips Would any of you be able to do a review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4437: Operator unit tests

Posted by parthchandra <gi...@git.apache.org>.

Github user parthchandra commented on the pull request:

    https://github.com/apache/drill/pull/394#issuecomment-192114749
  
    +1. Great to have this framework; nicely done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4437: Operator unit tests

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/394


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---