[GitHub] [sling-site] kwin commented on a diff in pull request #133: SLING-12052: add Pagefind for site search

["kwin (via GitHub)" <gi...@apache.org>]

kwin commented on code in PR #133:
URL: https://github.com/apache/sling-site/pull/133#discussion_r1340266334


##########
src/main/jbake/templates/layout/main.tpl:
##########
@@ -24,7 +24,7 @@ html(lang:'en'){
 
                     if( content ) {
                         if(content.title) {
-                            h1(class:"title") {
+                            h1(class:"title","data-pagefind-body":true) {

Review Comment:
   I am not sure this changes anything, as this is already considered (as below body, https://pagefind.app/docs/indexing/#limiting-what-sections-of-a-page-are-indexed). What about increasing the ranking with data-pagefind-weight="10" (or "9") for this particular h1?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org