You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/07/11 13:32:42 UTC
[PR] perf: optimize parse_url in datafusion-comet-spark-expr [datafusion-comet]
andygrove opened a new pull request, #4893:
URL: https://github.com/apache/datafusion-comet/pull/4893
> This PR was created by an LLM as a draft PR. I will mark it as ready for review after human review.
## Which issue does this PR close?
N/A — autonomous exploratory PR.
## Rationale for this change
Cache the compiled query regex in a thread-local single-slot cache keyed by the query key, eliminating per-row Regex::new() recompilation in parse_url's QUERY-with-key path (key is constant across a batch in practice).
## What changes are included in this PR?
Cache the compiled query regex in a thread-local single-slot cache keyed by the query key, eliminating per-row Regex::new() recompilation in parse_url's QUERY-with-key path (key is constant across a batch in practice).
## How are these changes tested?
Correctness: unit tests + seeded differential fuzz (bit-identical Arrow output vs `main`).
Benchmark (criterion):
- query_key: 97.999% faster (base 342913014ns -> cand 6862756ns)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: optimize `parse_url` (50x speedup) [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #4893:
URL: https://github.com/apache/datafusion-comet/pull/4893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org