[GitHub] [spark] zhengruifeng commented on a diff in pull request #37569: [SPARK-40138][PS][SQL] Implement DataFrame.mode

[GitBox <gi...@apache.org>]

zhengruifeng commented on code in PR #37569:
URL: https://github.com/apache/spark/pull/37569#discussion_r949747941


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##########
@@ -92,3 +93,75 @@ case class Mode(
   override protected def withNewChildInternal(newChild: Expression): Expression =
     copy(child = newChild)
 }
+
+/**
+ * Mode in Pandas' fashion. This expression is dedicated only for Pandas API on Spark.
+ */
+case class PandasMode(

Review Comment:
   since only `def merge` and `inputTypes` can be reused, so it maybe not worthwhile



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org