You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/07/16 15:51:32 UTC

[GitHub] [mynewt-nimble] mfarag13 commented on a change in pull request #503: nimble/gatt: Adding new API ble_gattc_read_long_full

mfarag13 commented on a change in pull request #503: nimble/gatt: Adding new API ble_gattc_read_long_full
URL: https://github.com/apache/mynewt-nimble/pull/503#discussion_r303988039
 
 

 ##########
 File path: nimble/host/src/ble_gattc.c
 ##########
 @@ -3172,17 +3176,17 @@ ble_gattc_read_long_rx_read_rsp(struct ble_gattc_proc *proc, int status,
 
     data_len = OS_MBUF_PKTLEN(*om);
 
-    attr.handle = proc->read_long.handle;
-    attr.offset = proc->read_long.offset;
-    attr.om = *om;
-
-    /* Report partial payload to application. */
-    rc = ble_gattc_read_long_cb(proc, status, 0, &attr);
+    /* Queue Partial Reading. */
 
 Review comment:
   @andrzej-kaczmarek I have added the new API that perform the Full reading and update the PR accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services