[GitHub] Chris2011 edited a comment on issue #1034: NETBEANS-1499 - change package.json icon

[GitBox <gi...@apache.org>]

Chris2011 edited a comment on issue #1034: NETBEANS-1499 - change package.json icon
URL: https://github.com/apache/incubator-netbeans/pull/1034#issuecomment-453730761
 
 
   @isaacs I'm really sry, that this is such annoying, for me too. It seems everything is about license and at the end, nothing is about license. But thx for you help anyway.
   
   To let you know, the icon is the offficial one, how should I find another one? It will be a custom one, from someone else, right? Or should I create my own based on that? If this is legally possible, I can do.
   
   > I'm also thinking if we really need the npm logo there. We could differentiate the file from a plain .js file with some hint. Even for Maven projects, we don't have a specific icon for pom.xml, we have the normal XML icon and we just group the pom.xml file under the "Project Files" subtree.
   
   Of course @emilianbold we have, beacuse I implemented it. It is a visual thing: https://github.com/apache/incubator-netbeans/pull/983 and there are lots of more coming: https://issues.apache.org/jira/browse/NETBEANS-1496
   
   Putting under the project files is not enough in my POV, as I said this is a visual thing, if you see the name, maybe you heard about it, but if you see the logo, you can guess that this is related to npm and for pom, it is related to maven etc. So yes I want to change some icons, which are only normal JS icons (also for JSON files, which doesn make sense but this is an other topic) to make them more promiment. I couldn't know that this is such a terrible process to find the right license or whatever.
   
   NetBeans still uses the karma logo for the test runner and where did you guys get it? What license is that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists