[jira] [Commented] (HDFS-9347) Invariant assumption in TestQuorumJournalManager.shutdown() is wrong

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138262#comment-15138262 ] 

Hudson commented on HDFS-9347:
------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #9265 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9265/])
Move HDFS-9347 from 2.8.0 to 2.6.5 in CHANGES.txt. (waltersu4549: rev acac72911e59a54414cc72c788626792b24af2f3)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Invariant assumption in TestQuorumJournalManager.shutdown() is wrong
> --------------------------------------------------------------------
>
>                 Key: HDFS-9347
>                 URL: https://issues.apache.org/jira/browse/HDFS-9347
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9347.001.patch, HDFS-9347.002.patch, HDFS-9347.003.patch, HDFS-9347.004.patch, HDFS-9347.005.patch, HDFS-9347.006.patch
>
>
> The code
> {code:title=TestTestQuorumJournalManager.java|borderStyle=solid}
> @After
>   public void shutdown() throws IOException {
>     IOUtils.cleanup(LOG, toClose.toArray(new Closeable[0]));
>     
>     // Should not leak clients between tests -- this can cause flaky tests.
>     // (See HDFS-4643)
>     GenericTestUtils.assertNoThreadsMatching(".*IPC Client.*");
>     
>     if (cluster != null) {
>       cluster.shutdown();
>     }
>   }
> {code}
> implicitly assumes when the call returns from IOUtils.cleanup() (which calls close() on QuorumJournalManager object), all IPC client connection threads are terminated. However, there is no internal implementation that enforces this assumption. Even if the bug reported in HADOOP-12532 is fixed, the internal code still only ensures IPC connections are terminated, but not the thread.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)