You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/05 01:58:23 UTC

[GitHub] [shardingsphere] huanghao495430759 opened a new issue #9596: DataNode constructor 'DataNode(final String dataNode)' may be throw invalid Exception when the args 'dataNode' without db name or table name

huanghao495430759 opened a new issue #9596:
URL: https://github.com/apache/shardingsphere/issues/9596


   ## Bug Report
   
   As the title
   
   ### Which version of ShardingSphere did you use?
   shardingshpere-5.0.0-RC1-SNAPSHOT
   ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?
   ShardingSphere-JDBC
   ### Expected behavior
   
   ### Actual behavior
   
   ### Reason analyze (If you can)
   
   when I  create a new DataNode instance as:
   `
   new DataNode("db.");
   new DataNode(".table");
   `
   It can work normally,but actually they are invalid instance, so I think the method isValidDataNode should be check this case.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] strongduanmu commented on issue #9596: DataNode constructor 'DataNode(final String dataNode)' may be throw invalid Exception when the args 'dataNode' without db name or table name

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #9596:
URL: https://github.com/apache/shardingsphere/issues/9596#issuecomment-946419426


   > @terrymanu can you please assign this issue to me?
   
   @puneetjakhar Welcome, I will assign this issue to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] puneetjakhar commented on issue #9596: DataNode constructor 'DataNode(final String dataNode)' may be throw invalid Exception when the args 'dataNode' without db name or table name

Posted by GitBox <gi...@apache.org>.
puneetjakhar commented on issue #9596:
URL: https://github.com/apache/shardingsphere/issues/9596#issuecomment-946356615


   @terrymanu can you please assign this issue to me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] strongduanmu closed issue #9596: DataNode constructor 'DataNode(final String dataNode)' may be throw invalid Exception when the args 'dataNode' without db name or table name

Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #9596:
URL: https://github.com/apache/shardingsphere/issues/9596


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] puneetjakhar commented on issue #9596: DataNode constructor 'DataNode(final String dataNode)' may be throw invalid Exception when the args 'dataNode' without db name or table name

Posted by GitBox <gi...@apache.org>.
puneetjakhar commented on issue #9596:
URL: https://github.com/apache/shardingsphere/issues/9596#issuecomment-947427909


   @strongduanmu can you please help me with adding the label Hacktoberfest and Hacktoberfest-accepted here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org